Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/ssh/vmware_vrni_known_privkey.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method initialize has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        {
Severity: Major
Found in modules/exploits/linux/ssh/vmware_vrni_known_privkey.rb - About 3 hrs to fix

    Method exploit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    if target.name == 'All'
      keys = targets.filter_map { |t| t.opts['key'] if t.name != 'All' }
    else
      keys = [target.opts['key']]
    Severity: Minor
    Found in modules/exploits/linux/ssh/vmware_vrni_known_privkey.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method do_login has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def do_login(user, key_data)
    opt_hash = ssh_client_defaults.merge({
      auth_methods: ['publickey'],
      port: rport,
      key_data: [ key_data ]
    Severity: Minor
    Found in modules/exploits/linux/ssh/vmware_vrni_known_privkey.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

            return nil
      Severity: Major
      Found in modules/exploits/linux/ssh/vmware_vrni_known_privkey.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return conn
        Severity: Major
        Found in modules/exploits/linux/ssh/vmware_vrni_known_privkey.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status