Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/browser/chrome_object_create.rb

Summary

Maintainability
D
2 days
Test Coverage

Method on_request_uri has 249 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def on_request_uri(cli, request)
    print_status("Sending #{request.uri} to #{request['User-Agent']}")
    download_payload = ''
    shellcode = payload.encoded
    uripath = datastore['URIPATH'] || get_resource
Severity: Major
Found in modules/exploits/multi/browser/chrome_object_create.rb - About 1 day to fix

    File chrome_object_create.rb has 320 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ManualRanking

  include Msf::Post::File
  include Msf::Exploit::Remote::HttpServer::BrowserExploit
    Severity: Minor
    Found in modules/exploits/multi/browser/chrome_object_create.rb - About 3 hrs to fix

      Method initialize has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Google Chrome 67, 68 and 69 Object.create exploit',
      Severity: Major
      Found in modules/exploits/multi/browser/chrome_object_create.rb - About 2 hrs to fix

        Method on_request_uri has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def on_request_uri(cli, request)
    print_status("Sending #{request.uri} to #{request['User-Agent']}")
    download_payload = ''
    shellcode = payload.encoded
    uripath = datastore['URIPATH'] || get_resource
        Severity: Minor
        Found in modules/exploits/multi/browser/chrome_object_create.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status