Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/atutor_upload_traversal.rb

Summary

Maintainability
D
2 days
Test Coverage

Method initialize has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'ATutor 2.2.4 - Directory Traversal / Remote Code Execution, ',
Severity: Major
Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 3 hrs to fix

    File atutor_upload_traversal.rb has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking
  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::CmdStager
  include Msf::Exploit::FileDropper
    Severity: Minor
    Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 2 hrs to fix

      Method check has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    vprint_status('Running check')
    res = send_request_cgi('method' => 'GET', 'uri' => normalize_uri(target_uri.path, 'login.php'))

    unless res
      Severity: Minor
      Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_zip_and_upload has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create_zip_and_upload(exploit)
    @pl_file = Rex::Text.rand_text_alpha_lower(6..10)
    @pl_file << '.php'
    register_file_for_cleanup(@pl_file)
    @header = Rex::Text.rand_text_alpha_upper(4)
      Severity: Major
      Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 2 hrs to fix

        Method create_zip_and_upload has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def create_zip_and_upload(exploit)
    @pl_file = Rex::Text.rand_text_alpha_lower(6..10)
    @pl_file << '.php'
    register_file_for_cleanup(@pl_file)
    @header = Rex::Text.rand_text_alpha_upper(4)
        Severity: Minor
        Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check
    vprint_status('Running check')
    res = send_request_cgi('method' => 'GET', 'uri' => normalize_uri(target_uri.path, 'login.php'))

    unless res
        Severity: Minor
        Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 1 hr to fix

          Method login has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def login
    hashed_pass = Rex::Text.sha1(datastore['PASSWORD'])
    @token = Rex::Text.rand_text_alpha_lower(5..8)
    hashed_pass << @token
    hash_final = Rex::Text.sha1(hashed_pass)
          Severity: Minor
          Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 1 hr to fix

            Method patcher_csrf_token has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              def patcher_csrf_token(upload_url)
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => upload_url,
      'cookie' => @cookie
            Severity: Minor
            Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method exploit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def exploit
    res = login
    if target.name == 'Auto'
      select_target(res)
    else
            Severity: Minor
            Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Unknown("Target is ATutor with version #{@version}.")
            Severity: Major
            Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return CheckCode::Detected('Unable to obtain ATutor version. However, the project is no longer maintained, so the target is likely vulnerable.')
              Severity: Major
              Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 30 mins to fix

                Method login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def login
    hashed_pass = Rex::Text.sha1(datastore['PASSWORD'])
    @token = Rex::Text.rand_text_alpha_lower(5..8)
    hashed_pass << @token
    hash_final = Rex::Text.sha1(hashed_pass)
                Severity: Minor
                Found in modules/exploits/multi/http/atutor_upload_traversal.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    register_options [
      OptString.new('TARGETURI', [true, 'The base path to ATutor', '/ATutor/']),
      OptString.new('USERNAME', [true, 'Username to authenticate with', '']),
      OptString.new('PASSWORD', [true, 'Password to authenticate with', '']),
      OptString.new('FILE_TRAVERSAL_PATH', [false, 'Traversal path to the root server directory.', ''])
                Severity: Minor
                Found in modules/exploits/multi/http/atutor_upload_traversal.rb and 3 other locations - About 25 mins to fix
                modules/auxiliary/scanner/http/cisco_firepower_download.rb on lines 38..45
                modules/exploits/multi/fileformat/visual_studio_vsix_exec.rb on lines 53..58
                modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb on lines 51..57

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 30.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status