Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/bassmaster_js_injection.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method initialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Bassmaster Batch Arbitrary JavaScript Injection Remote Code Execution',
      'Description'    => %q{
        This module exploits an un-authenticated code injection vulnerability in the bassmaster
Severity: Minor
Found in modules/exploits/multi/http/bassmaster_js_injection.rb - About 1 hr to fix

    Identical blocks of code found in 11 locations. Consider refactoring.
    Open

      def on_request_uri(cli, request)
    if (not @pl)
      print_error("#{rhost}:#{rport} - A request came in, but the payload wasn't ready yet!")
      return
    end
    Severity: Major
    Found in modules/exploits/multi/http/bassmaster_js_injection.rb and 10 other locations - About 20 mins to fix
    modules/exploits/linux/http/dlink_diagnostic_exec_noauth.rb on lines 198..206
    modules/exploits/linux/http/dlink_dir615_up_exec.rb on lines 233..241
    modules/exploits/linux/http/linksys_e1500_apply_exec.rb on lines 226..234
    modules/exploits/linux/http/linksys_wrt54gl_apply_exec.rb on lines 393..401
    modules/exploits/linux/http/netgear_dgn1000b_setup_exec.rb on lines 230..238
    modules/exploits/linux/http/netgear_dgn2200b_pppoe_exec.rb on lines 335..343
    modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 85..92
    modules/exploits/multi/http/rails_dynamic_render_code_exec.rb on lines 95..102
    modules/exploits/multi/http/trendmicro_threat_discovery_admin_sys_time_cmdi.rb on lines 137..144
    modules/exploits/multi/sap/sap_mgmt_con_osexec_payload.rb on lines 298..306

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

        if (datastore['SRVHOST'] == "0.0.0.0" or datastore['SRVHOST'] == "::")
      srv_host = datastore['URIHOST'] || Rex::Socket.source_address(rhost)
    else
      srv_host = datastore['SRVHOST']
    end
    Severity: Minor
    Found in modules/exploits/multi/http/bassmaster_js_injection.rb and 3 other locations - About 15 mins to fix
    modules/exploits/linux/smtp/exim4_dovecot_exec.rb on lines 123..127
    modules/exploits/multi/http/rails_dynamic_render_code_exec.rb on lines 159..163
    modules/exploits/multi/http/trendmicro_threat_discovery_admin_sys_time_cmdi.rb on lines 160..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status