Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/cacti_package_import_rce.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Cacti Import Packages RCE',
Severity: Major
Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 3 hrs to fix

    Method upload_package has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def upload_package
    print_status('Uploading the package')
    # Default parameters sent when importing packages from the web UI
    # Randomizing these values might be suspicious
    vars_form = {
    Severity: Minor
    Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 1 hr to fix

      Method exploit has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    # Setting the `FETCH_DELETE` option seems to break the payload execution.
    # `Msf::Exploit::FileDropper` will be used later to cleanup. Note that it
    # is not possible to opt-out anymore.
    fail_with(Failure::BadConfig, 'FETCH_DELETE must be set to false') if datastore['FETCH_DELETE']
      Severity: Minor
      Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    # Step 1 - Check if the target is Cacti and get the version
    print_status('Checking Cacti version')
    res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'index.php'),
      Severity: Minor
      Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    # Step 1 - Check if the target is Cacti and get the version
    print_status('Checking Cacti version')
    res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'index.php'),
        Severity: Minor
        Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method upload_package has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def upload_package
    print_status('Uploading the package')
    # Default parameters sent when importing packages from the web UI
    # Randomizing these values might be suspicious
    vars_form = {
        Severity: Minor
        Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return CheckCode::Unknown("Could not access `package_import.php` - unexpected HTTP response code: #{res.code}") unless res.code == 200
        Severity: Major
        Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return CheckCode::Unknown('Could not get the CSRF token from `index.php`') if @csrf_token.empty?
          Severity: Major
          Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Safe('Could not access `package_import.php` - insufficient permissions')
            Severity: Major
            Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return CheckCode::Unknown("Login failed: #{e}")
              Severity: Major
              Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return CheckCode::Unknown('Could not access `package_import.php` - no response') if res.nil?
                Severity: Major
                Found in modules/exploits/multi/http/cacti_package_import_rce.rb - About 30 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                        begin
        do_login(datastore['USERNAME'], datastore['PASSWORD'], csrf_token: @csrf_token)
      rescue CactiError => e
        fail_with(Failure::NoAccess, "Login failure: #{e.class} - #{e}")
      end
                  Severity: Minor
                  Found in modules/exploits/multi/http/cacti_package_import_rce.rb and 1 other location - About 15 mins to fix
                  modules/exploits/multi/http/cacti_pollers_sqli_rce.rb on lines 264..268

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 26.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status