Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/cisco_dcnm_upload_2019.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Cisco Data Center Network Manager Unauthenticated Remote Code Execution',
      'Description'    => %q{
        DCNM exposes a file upload servlet (FileUploadServlet) at /fm/fileUpload.
Severity: Major
Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb - About 2 hrs to fix

    Method exploit has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    target = target_select

    if target == targets[2]
      jsession = auth_v11
    Severity: Minor
    Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb - About 1 hr to fix

      Method get_war_path has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_war_path
    res = send_request_cgi(
      'uri'    => normalize_uri(target_uri.path, 'fm', 'log', 'fmlogs.zip'),
      'method' => 'GET'
    )
      Severity: Minor
      Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method exploit has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    target = target_select

    if target == targets[2]
      jsession = auth_v11
      Severity: Minor
      Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method target_select has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def target_select
    if target != targets[0]
      return target
    else
      res = send_request_cgi(
      Severity: Minor
      Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method target_select has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def target_select
    if target != targets[0]
      return target
    else
      res = send_request_cgi(
      Severity: Minor
      Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb - About 1 hr to fix

        Method auth_v10 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def auth_v10
    # step 1: get a JSESSIONID cookie and the server Date header
    res = send_request_cgi(
      'uri'    => normalize_uri(target_uri.path, 'fm/'),
      'method' => 'GET'
        Severity: Minor
        Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb - About 1 hr to fix

          Method auth_v11 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def auth_v11
    res = send_request_cgi(
      'uri'    => normalize_uri(target_uri.path, 'fm/'),
      'method' => 'GET',
      'vars_get'  =>
          Severity: Minor
          Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                    return targets[3]
          Severity: Major
          Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              def auth_v11
    res = send_request_cgi(
      'uri'    => normalize_uri(target_uri.path, 'fm/'),
      'method' => 'GET',
      'vars_get'  =>
            Severity: Minor
            Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb and 1 other location - About 55 mins to fix
            modules/auxiliary/admin/networking/cisco_dcnm_download.rb on lines 56..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                register_options(
      [
        Opt::RPORT(443),
        OptBool.new('SSL', [true, 'Connect with TLS', true]),
        OptString.new('TARGETURI', [true,  "Default server path", '/']),
            Severity: Major
            Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb and 6 other locations - About 30 mins to fix
            modules/auxiliary/admin/http/manageengine_pmp_privesc.rb on lines 41..48
            modules/auxiliary/gather/mcafee_epo_xxe.rb on lines 46..53
            modules/exploits/linux/http/f5_icall_cmd.rb on lines 52..59
            modules/exploits/linux/http/f5_icontrol_exec.rb on lines 39..46
            modules/exploits/linux/http/lifesize_uvc_ping_rce.rb on lines 47..54
            modules/exploits/windows/ibm/ibm_was_dmgr_java_deserialization_rce.rb on lines 51..58

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status