rapid7/metasploit-framework

View on GitHub
modules/exploits/multi/http/clipbucket_fileupload_exec.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info={})
    super(update_info(info,
      'Name'           => "ClipBucket beats_uploader Unauthenticated Arbitrary File Upload",
      'Description'    => %q{
        This module exploits a vulnerability found in ClipBucket versions before 4.0.0 (Release 4902).
Severity: Minor
Found in modules/exploits/multi/http/clipbucket_fileupload_exec.rb - About 1 hr to fix

    Method exploit has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    
        # generate the PHP meterpreter payload
        stager = '<?php '
        stager << payload.encode
    Severity: Minor
    Found in modules/exploits/multi/http/clipbucket_fileupload_exec.rb - About 1 hr to fix

      Method check has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
          vprint_status('Trying to detect ClipBucket on target.')
      
          # check for readme file
          res = send_request_cgi({
      Severity: Minor
      Found in modules/exploits/multi/http/clipbucket_fileupload_exec.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
            vprint_status('Trying to detect ClipBucket on target.')
        
            # check for readme file
            res = send_request_cgi({
        Severity: Minor
        Found in modules/exploits/multi/http/clipbucket_fileupload_exec.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status