Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/coldfusion_rds_auth_bypass.rb

Summary

Maintainability
D
1 day
Test Coverage

Method upload_payload has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def upload_payload
    uri = target_uri.path

    @filename = rand_text_alpha(8+rand(8)) + ".cfm" #numbers is a bad idea
    taskname = rand_text_alpha(8+rand(8)) #numbers is a bad idea
Severity: Major
Found in modules/exploits/multi/http/coldfusion_rds_auth_bypass.rb - About 3 hrs to fix

    Method upload_payload has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      def upload_payload
    uri = target_uri.path

    @filename = rand_text_alpha(8+rand(8)) + ".cfm" #numbers is a bad idea
    taskname = rand_text_alpha(8+rand(8)) #numbers is a bad idea
    Severity: Minor
    Found in modules/exploits/multi/http/coldfusion_rds_auth_bypass.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File coldfusion_rds_auth_bypass.rb has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::Remote::HttpServer::HTML
  include Msf::Exploit::EXE
    Severity: Minor
    Found in modules/exploits/multi/http/coldfusion_rds_auth_bypass.rb - About 2 hrs to fix

      Method initialize has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(info,
      'Name'            => 'Adobe ColdFusion RDS Authentication Bypass',
      'Description'     => %q{
        Adobe ColdFusion 9.0, 9.0.1, 9.0.2, and 10 allows remote
      Severity: Major
      Found in modules/exploits/multi/http/coldfusion_rds_auth_bypass.rb - About 2 hrs to fix

        Method check has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check
    uri = target_uri.path

    #can we access the admin interface?
    res = send_request_cgi({
        Severity: Minor
        Found in modules/exploits/multi/http/coldfusion_rds_auth_bypass.rb - About 1 hr to fix

          Method check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def check
    uri = target_uri.path

    #can we access the admin interface?
    res = send_request_cgi({
          Severity: Minor
          Found in modules/exploits/multi/http/coldfusion_rds_auth_bypass.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def exploit
    @pl           = gen_file_dropper
    @payload_url  = ""

    if datastore['EXTURL'].blank?
          Severity: Minor
          Found in modules/exploits/multi/http/coldfusion_rds_auth_bypass.rb and 1 other location - About 30 mins to fix
          modules/exploits/linux/antivirus/escan_password_exec.rb on lines 112..126

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status