Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/git_client_command_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(
      info,
      'Name' => 'Malicious Git and Mercurial HTTP Server For CVE-2014-9390',
      'Description' => %q(
Severity: Major
Found in modules/exploits/multi/http/git_client_command_exec.rb - About 3 hrs to fix

    File git_client_command_exec.rb has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpServer
  include Msf::Exploit::Git
    Severity: Minor
    Found in modules/exploits/multi/http/git_client_command_exec.rb - About 2 hrs to fix

      Method setup_git has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def setup_git
    return unless datastore['GIT']
    # URI must start with a /
    unless git_uri && git_uri =~ /^\//
      fail_with(Failure::BadConfig, 'GIT_URI must start with a /')
      Severity: Minor
      Found in modules/exploits/multi/http/git_client_command_exec.rb - About 1 hr to fix

        Method setup_git has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def setup_git
    return unless datastore['GIT']
    # URI must start with a /
    unless git_uri && git_uri =~ /^\//
      fail_with(Failure::BadConfig, 'GIT_URI must start with a /')
        Severity: Minor
        Found in modules/exploits/multi/http/git_client_command_exec.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method do_html has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def do_html(cli, _req)
    resp = create_response
    resp.body = <<HTML
     <html>
      <head><title>Public Repositories</title></head>
        Severity: Minor
        Found in modules/exploits/multi/http/git_client_command_exec.rb - About 1 hr to fix

          Method setup_mercurial has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def setup_mercurial
    return unless datastore['MERCURIAL']
    # URI must start with a /
    unless mercurial_uri && mercurial_uri =~ /^\//
      fail_with(Failure::BadConfig, 'MERCURIAL_URI must start with a /')
          Severity: Minor
          Found in modules/exploits/multi/http/git_client_command_exec.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              register_advanced_options(
      [
        OptString.new('GIT_URI', [false, 'The URI to use as the malicious Git instance (empty for random)', '']),
        OptString.new('MERCURIAL_URI', [false, 'The URI to use as the malicious Mercurial instance (empty for random)', '']),
        OptString.new('GIT_HOOK', [false, 'The Git hook to use for exploitation', 'post-checkout']),
          Severity: Minor
          Found in modules/exploits/multi/http/git_client_command_exec.rb and 1 other location - About 40 mins to fix
          modules/auxiliary/server/capture/http_ntlm.rb on lines 44..50

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 37.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 22 locations. Consider refactoring.
          Open

                    ['CVE', '2014-9390'],
          ['URL', 'https://www.rapid7.com/blog/post/2015/01/01/12-days-of-haxmas-exploiting-cve-2014-9390-in-git-and-mercurial'],
          ['URL', 'http://git-blame.blogspot.com.es/2014/12/git-1856-195-205-214-and-221-and.html'],
          ['URL', 'http://article.gmane.org/gmane.linux.kernel/1853266'],
          ['URL', 'https://github.com/blog/1938-vulnerability-announced-update-your-git-clients'],
          Severity: Major
          Found in modules/exploits/multi/http/git_client_command_exec.rb and 21 other locations - About 20 mins to fix
          modules/auxiliary/dos/http/hashcollision_dos.rb on lines 36..44
          modules/auxiliary/scanner/http/wp_woocommerce_payments_add_user.rb on lines 61..69
          modules/exploits/android/browser/webview_addjavascriptinterface.rb on lines 58..66
          modules/exploits/freebsd/local/rtld_execl_priv_esc.rb on lines 57..65
          modules/exploits/linux/http/apache_superset_cookie_sig_rce.rb on lines 32..40
          modules/exploits/linux/http/zimbra_cpio_cve_2022_41352.rb on lines 44..52
          modules/exploits/linux/local/bpf_priv_esc.rb on lines 48..56
          modules/exploits/linux/local/cve_2021_3490_ebpf_alu32_bounds_check_lpe.rb on lines 53..61
          modules/exploits/linux/local/glibc_realpath_priv_esc.rb on lines 48..56
          modules/exploits/linux/local/systemtap_modprobe_options_priv_esc.rb on lines 43..51
          modules/exploits/linux/misc/cisco_ios_xe_rce.rb on lines 52..65
          modules/exploits/linux/misc/lprng_format_string.rb on lines 26..34
          modules/exploits/linux/upnp/dlink_upnp_msearch_exec.rb on lines 70..78
          modules/exploits/multi/browser/java_jre17_exec.rb on lines 43..51
          modules/exploits/multi/http/vtiger_soap_upload.rb on lines 33..41
          modules/exploits/windows/browser/ms13_022_silverlight_script_object.rb on lines 40..48
          modules/exploits/windows/browser/webex_ucf_newobject.rb on lines 40..48
          modules/exploits/windows/fileformat/allplayer_m3u_bof.rb on lines 31..39
          modules/exploits/windows/http/exchange_chainedserializationbinder_rce.rb on lines 45..54
          modules/exploits/windows/http/exchange_ecp_dlp_policy.rb on lines 49..57
          modules/exploits/windows/http/netgear_nms_rce.rb on lines 32..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 28.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def git_uri
    return @git_uri if @git_uri
    if datastore['GIT_URI'].blank?
      @git_uri = '/' + Rex::Text.rand_text_alpha(rand(10) + 2).downcase + '.git'
    else
          Severity: Minor
          Found in modules/exploits/multi/http/git_client_command_exec.rb and 1 other location - About 20 mins to fix
          modules/exploits/multi/http/git_submodule_command_exec.rb on lines 179..184

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 28.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if datastore['MERCURIAL']
      this_mercurial_uri = URI.parse(get_uri).merge(mercurial_uri)
      resp.body << "<li><a href=#{mercurial_uri}>Mercurial</a> (clone with `hg clone #{this_mercurial_uri}`)</li>"
    else
      resp.body << "<li><a>Mercurial</a> (currently offline)</li>"
          Severity: Minor
          Found in modules/exploits/multi/http/git_client_command_exec.rb and 1 other location - About 15 mins to fix
          modules/exploits/multi/http/git_client_command_exec.rb on lines 297..301

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if datastore['GIT']
      this_git_uri = URI.parse(get_uri).merge(git_uri)
      resp.body << "<li><a href=#{git_uri}>Git</a> (clone with `git clone #{this_git_uri}`)</li>"
    else
      resp.body << "<li><a>Git</a> (currently offline)</li>"
          Severity: Minor
          Found in modules/exploits/multi/http/git_client_command_exec.rb and 1 other location - About 15 mins to fix
          modules/exploits/multi/http/git_client_command_exec.rb on lines 304..308

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status