Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/gitea_git_fetch_rce.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method initialize has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Gitea Git Fetch Remote Code Execution',
Severity: Major
Found in modules/exploits/multi/http/gitea_git_fetch_rce.rb - About 3 hrs to fix

    Method on_request_uri has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def on_request_uri(cli, req)
    case req.uri
    when '/api/v1/version'
      send_response(cli, '{"version": "1.16.6"}')
    when '/api/v1/settings/api'
    Severity: Minor
    Found in modules/exploits/multi/http/gitea_git_fetch_rce.rb - About 1 hr to fix

      Method exploit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    unless datastore['AutoCheck']
      fail_with(Failure::BadConfig, 'USERNAME can\'t be blank') if datastore['username'].blank?
      gitea_login(datastore['username'], datastore['password'])
    end
      Severity: Minor
      Found in modules/exploits/multi/http/gitea_git_fetch_rce.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method cleanup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def cleanup
    super
    return if @uid.nil? || @migrate_repo_created.nil?

    [@repo_name, @migrate_repo_name].each do |name|
      Severity: Minor
      Found in modules/exploits/multi/http/gitea_git_fetch_rce.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

          return CheckCode::Safe(e.message)
      Severity: Major
      Found in modules/exploits/multi/http/gitea_git_fetch_rce.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status