Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/glassfish_deployer.rb

Summary

Maintainability
F
4 days
Test Coverage

File glassfish_deployer.rb has 647 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'nokogiri'
require 'metasploit/framework/login_scanner/glassfish'
require 'metasploit/framework/credential_collection'

class MetasploitModule < Msf::Exploit::Remote
Severity: Major
Found in modules/exploits/multi/http/glassfish_deployer.rb - About 1 day to fix

    Method get_upload_data has 148 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_upload_data(opts = {})
    boundary = opts[:boundary]
    version = opts[:version]
    war = opts[:war]
    app_base = opts[:app_base]
    Severity: Major
    Found in modules/exploits/multi/http/glassfish_deployer.rb - About 5 hrs to fix

      Method upload_exec has 87 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def upload_exec(opts = {})
    session = opts[:session]
    app_base = opts[:app_base]
    jsp_name = opts[:jsp_name]
    war = opts[:war]
      Severity: Major
      Found in modules/exploits/multi/http/glassfish_deployer.rb - About 3 hrs to fix

        Class MetasploitModule has 24 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::EXE
        Severity: Minor
        Found in modules/exploits/multi/http/glassfish_deployer.rb - About 2 hrs to fix

          Method upload_exec has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

            def upload_exec(opts = {})
    session = opts[:session]
    app_base = opts[:app_base]
    jsp_name = opts[:jsp_name]
    war = opts[:war]
          Severity: Minor
          Found in modules/exploits/multi/http/glassfish_deployer.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method get_delete_info has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

            def get_delete_info(session, version, app='')
    if version == '2.x' || version == '9.x'
      path = '/applications/webApplications.jsf'
      res = send_glassfish_request(path, @verbs['GET'], session)
          Severity: Minor
          Found in modules/exploits/multi/http/glassfish_deployer.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method get_delete_info has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def get_delete_info(session, version, app='')
    if version == '2.x' || version == '9.x'
      path = '/applications/webApplications.jsf'
      res = send_glassfish_request(path, @verbs['GET'], session)
          Severity: Minor
          Found in modules/exploits/multi/http/glassfish_deployer.rb - About 1 hr to fix

            Method initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def initialize(info={})
    super(update_info(info,
      'Name'           => "Sun/Oracle GlassFish Server Authenticated Code Execution",
      'Description'    => %q{
          This module logs in to a GlassFish Server (Open Source or Commercial) using various
            Severity: Minor
            Found in modules/exploits/multi/http/glassfish_deployer.rb - About 1 hr to fix

              Method exploit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                def exploit
    # Invoke index to gather some info
    res = send_glassfish_request('/common/index.jsf', 'GET')

    if res.code == 302
              Severity: Minor
              Found in modules/exploits/multi/http/glassfish_deployer.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method try_normal_login has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def try_normal_login(version)
    init_loginscanner

    case version
    when /2\.x|9\.x/
              Severity: Minor
              Found in modules/exploits/multi/http/glassfish_deployer.rb - About 1 hr to fix

                Method try_glassfish_auth_bypass has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                  def try_glassfish_auth_bypass(version)
    sid = nil

    if version == '2.x' || version == '9.x'
      print_status("Trying auth bypass...")
                Severity: Minor
                Found in modules/exploits/multi/http/glassfish_deployer.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method exploit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def exploit
    # Invoke index to gather some info
    res = send_glassfish_request('/common/index.jsf', 'GET')

    if res.code == 302
                Severity: Minor
                Found in modules/exploits/multi/http/glassfish_deployer.rb - About 1 hr to fix

                  Method auto_target has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def auto_target(session, res, version)
    print_status("Attempting to automatically select a target...")

    res = query_serverinfo(session, version)
    return nil unless res
                  Severity: Minor
                  Found in modules/exploits/multi/http/glassfish_deployer.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method get_version has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def get_version(res)
    # Extract banner from response
    banner = res.headers['Server']

    # Default value for edition and glassfish version
                  Severity: Minor
                  Found in modules/exploits/multi/http/glassfish_deployer.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method send_glassfish_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    def send_glassfish_request(path, method, session='', data=nil, ctype=nil)
                  Severity: Minor
                  Found in modules/exploits/multi/http/glassfish_deployer.rb - About 35 mins to fix

                    Method query_serverinfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def query_serverinfo(session,version)
    res = ''

    if version == '2.x' || version == '9.x'
      path = "/appServer/jvmReport.jsf?instanceName=server&pageTitle=JVM%20Report"
                    Severity: Minor
                    Found in modules/exploits/multi/http/glassfish_deployer.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          print_status("Trying auth bypass...")
      res = send_glassfish_request('/common/applications/uploadFrame.jsf', 'get')
      title = '<title>Deploy Applications or Modules'
      if res && res.code.to_i == 200 && res.body.include?(title)
        sid = res.get_cookies.to_s.scan(/JSESSIONID=(.*); */).flatten.first
                    Severity: Minor
                    Found in modules/exploits/multi/http/glassfish_deployer.rb and 1 other location - About 25 mins to fix
                    modules/exploits/multi/http/glassfish_deployer.rb on lines 699..704

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 30.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          print_status("Trying auth bypass...")
      res = send_glassfish_request('/applications/upload.jsf', 'get')
      title = '<title>Deploy Enterprise Applications/Modules</title>'
      if res && res.code.to_i == 200 && res.body.include?(title)
        sid = res.get_cookies.to_s.scan(/JSESSIONID=(.*); */).flatten.first
                    Severity: Minor
                    Found in modules/exploits/multi/http/glassfish_deployer.rb and 1 other location - About 25 mins to fix
                    modules/exploits/multi/http/glassfish_deployer.rb on lines 707..712

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 30.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status