Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/jenkins_metaprogramming.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method initialize has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'               => 'Jenkins ACL Bypass and Metaprogramming RCE',
      'Description'        => %q{
        This module exploits a vulnerability in Jenkins dynamic routing to
Severity: Major
Found in modules/exploits/multi/http/jenkins_metaprogramming.rb - About 2 hrs to fix

    Method check has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    checkcode = CheckCode::Safe

    res = send_request_cgi(
      'method'   => 'GET',
    Severity: Minor
    Found in modules/exploits/multi/http/jenkins_metaprogramming.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    checkcode = CheckCode::Safe

    res = send_request_cgi(
      'method'   => 'GET',
      Severity: Minor
      Found in modules/exploits/multi/http/jenkins_metaprogramming.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method on_request_uri has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, request)
    vprint_status("#{request.method} #{request.uri} requested")

    unless %w[HEAD GET].include?(request.method)
      vprint_error("Ignoring #{request.method} request")
      Severity: Minor
      Found in modules/exploits/multi/http/jenkins_metaprogramming.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              ['CVE', '2018-1000861'], # Orange Tsai
        ['CVE', '2019-1003000'], # Script Security
        ['CVE', '2019-1003001'], # Pipeline: Groovy
        ['CVE', '2019-1003002'], # Pipeline: Declarative
        ['CVE', '2019-1003005'], # Mikhail Egorov
      Severity: Major
      Found in modules/exploits/multi/http/jenkins_metaprogramming.rb and 3 other locations - About 45 mins to fix
      modules/exploits/linux/local/abrt_raceabrt_priv_esc.rb on lines 48..60
      modules/exploits/linux/local/nested_namespace_idmap_limit_priv_esc.rb on lines 50..62
      modules/exploits/windows/smb/smb_doublepulsar_rce.rb on lines 36..48

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status