Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/jetbrains_teamcity_rce_cve_2023_42793.rb

Summary

Maintainability
C
1 day
Test Coverage

Method exploit has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    token_uri = "/app/rest/users/id:#{datastore['TEAMCITY_ADMIN_ID']}/tokens/RPC2"

    res = send_request_cgi(
      'method' => 'POST',
Severity: Major
Found in modules/exploits/multi/http/jetbrains_teamcity_rce_cve_2023_42793.rb - About 2 hrs to fix

    Method exploit has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    token_uri = "/app/rest/users/id:#{datastore['TEAMCITY_ADMIN_ID']}/tokens/RPC2"

    res = send_request_cgi(
      'method' => 'POST',
    Severity: Minor
    Found in modules/exploits/multi/http/jetbrains_teamcity_rce_cve_2023_42793.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'JetBrains TeamCity Unauthenticated Remote Code Execution',
    Severity: Major
    Found in modules/exploits/multi/http/jetbrains_teamcity_rce_cve_2023_42793.rb - About 2 hrs to fix

      Method modify_internal_properties has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def modify_internal_properties(token, key, value)
    res = send_request_cgi(
      'method' => 'POST',
      'uri' => normalize_uri('/admin/dataDir.html'),
      'headers' => {
      Severity: Minor
      Found in modules/exploits/multi/http/jetbrains_teamcity_rce_cve_2023_42793.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    res = send_request_cgi(
      'method' => 'GET',
      'uri' => '/login.html'
    )
        Severity: Minor
        Found in modules/exploits/multi/http/jetbrains_teamcity_rce_cve_2023_42793.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method modify_internal_properties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def modify_internal_properties(token, key, value)
    res = send_request_cgi(
      'method' => 'POST',
      'uri' => normalize_uri('/admin/dataDir.html'),
      'headers' => {
        Severity: Minor
        Found in modules/exploits/multi/http/jetbrains_teamcity_rce_cve_2023_42793.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status