Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/jira_plugin_upload.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method upload_exec has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def upload_exec(upm_token, good_cookie)
    contents = ''
    name = Rex::Text.rand_text_alpha(8..12)

    atlassian_plugin_xml = %Q{
Severity: Major
Found in modules/exploits/multi/http/jira_plugin_upload.rb - About 2 hrs to fix

    Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'        => 'Atlassian Jira Authenticated Upload Code Execution',
      'Description' => %q{
        This module can be used to execute a payload on Atlassian Jira via
    Severity: Minor
    Found in modules/exploits/multi/http/jira_plugin_upload.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    login_res = query_login
    if login_res.nil?
      vprint_error('Unable to access the web application!')
      return CheckCode::Unknown
      Severity: Minor
      Found in modules/exploits/multi/http/jira_plugin_upload.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return Exploit::CheckCode::Unknown
      Severity: Major
      Found in modules/exploits/multi/http/jira_plugin_upload.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return Exploit::CheckCode::Appears
        Severity: Major
        Found in modules/exploits/multi/http/jira_plugin_upload.rb - About 30 mins to fix

          Method access_login? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def access_login?
    res = query_login
    if res.nil?
      fail_with(Failure::Unknown, 'Unable to access the web application!')
    end
          Severity: Minor
          Found in modules/exploits/multi/http/jira_plugin_upload.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status