Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/lucee_scheduled_job.rb

Summary

Maintainability
D
1 day
Test Coverage

Method create_job has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_job(payload_base)
    create_job = send_request_cgi({
      'method' => 'POST',
      'uri' => normalize_uri(target_uri.path),
      'keep_cookies' => true,
Severity: Major
Found in modules/exploits/multi/http/lucee_scheduled_job.rb - About 3 hrs to fix

    Method execute_job has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def execute_job(payload_base)
    print_status("Executing scheduled job: #{payload_base}")
    job_execution = send_request_cgi({
      'method' => 'POST',
      'uri' => normalize_uri(target_uri.path),
    Severity: Minor
    Found in modules/exploits/multi/http/lucee_scheduled_job.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File lucee_scheduled_job.rb has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::Remote::HttpServer::HTML
    Severity: Minor
    Found in modules/exploits/multi/http/lucee_scheduled_job.rb - About 2 hrs to fix

      Method initialize has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Lucee Authenticated Scheduled Job Code Execution',
      Severity: Major
      Found in modules/exploits/multi/http/lucee_scheduled_job.rb - About 2 hrs to fix

        Method execute_job has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def execute_job(payload_base)
    print_status("Executing scheduled job: #{payload_base}")
    job_execution = send_request_cgi({
      'method' => 'POST',
      'uri' => normalize_uri(target_uri.path),
        Severity: Minor
        Found in modules/exploits/multi/http/lucee_scheduled_job.rb - About 1 hr to fix

          Method exploit has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def exploit
    payload_base = rand_text_alphanumeric(8..16)
    authenticate

    start_service({
          Severity: Minor
          Found in modules/exploits/multi/http/lucee_scheduled_job.rb - About 1 hr to fix

            Method create_job has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def create_job(payload_base)
    create_job = send_request_cgi({
      'method' => 'POST',
      'uri' => normalize_uri(target_uri.path),
      'keep_cookies' => true,
            Severity: Minor
            Found in modules/exploits/multi/http/lucee_scheduled_job.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status