Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/magento_unserialize.rb

Summary

Maintainability
D
1 day
Test Coverage

File magento_unserialize.rb has 359 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::FileDropper
Severity: Minor
Found in modules/exploits/multi/http/magento_unserialize.rb - About 4 hrs to fix

    Method get_phpinfo has 100 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_phpinfo
    # uses the Magento_Framework_DB_Transaction class
    serialize =  'O:13:\"Credis_Client\":22:{'
    serialize << 's:8:\"\u0000*\u0000redis\";'
    serialize << 'O:45:\"Magento\\\Sales\\\Model\\\Order\\\Payment\\\Transaction\":40:{'
    Severity: Major
    Found in modules/exploits/multi/http/magento_unserialize.rb - About 4 hrs to fix

      Method get_phpshell has 99 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_phpshell
    s = "#{@webroot}/#{@backdoor}"
    p = "<?php #{payload.encoded} ?>"
    # uses the Magento_Framework_Simplexml_Config_Cache_File class
    serialize  = 'O:13:\"Credis_Client\":22:{'
      Severity: Major
      Found in modules/exploits/multi/http/magento_unserialize.rb - About 3 hrs to fix

        Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Magento 2.0.6 Unserialize Remote Code Execution',
      'Description'    => %q{
        This module exploits a PHP object injection vulnerability in Magento 2.0.6
        Severity: Minor
        Found in modules/exploits/multi/http/magento_unserialize.rb - About 1 hr to fix

          Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def check
    define_globals
    # we actually exploit the bug, but just for a callback
    begin
      if create_fake_cart
          Severity: Minor
          Found in modules/exploits/multi/http/magento_unserialize.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status