Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/manageengine_search_sqli.rb

Summary

Maintainability
B
7 hrs
Test Coverage

Method generate_jsp_payload has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def generate_jsp_payload
    opts                = {:arch => @my_target.arch, :platform => @my_target.platform}
    native_payload      = Rex::Text.encode_base64(generate_payload_exe(opts))
    native_payload_name = Rex::Text.rand_text_alpha(rand(6)+3)
    ext                 = (@my_target['Platform'] == 'win') ? '.exe' : '.bin'
Severity: Minor
Found in modules/exploits/multi/http/manageengine_search_sqli.rb - About 1 hr to fix

    Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info={})
    super(update_info(info,
      'Name'           => "ManageEngine Security Manager Plus 5.5 Build 5505 SQL Injection",
      'Description'    => %q{
          This module exploits a SQL injection found in ManageEngine Security Manager Plus
    Severity: Minor
    Found in modules/exploits/multi/http/manageengine_search_sqli.rb - About 1 hr to fix

      Method sqli_exec has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def sqli_exec(sqli_string)
    cookie  = 'STATE_COOKIE=&'
    cookie << 'SecurityManager/ID/174/HomePageSubDAC_LIST/223/SecurityManager_CONTENTAREA_LIST/226/MainDAC_LIST/166&'
    cookie << 'MainTabs/ID/167/_PV/174/selectedView/Home&'
    cookie << 'Home/ID/166/PDCA/MainDAC/_PV/174&'
      Severity: Minor
      Found in modules/exploits/multi/http/manageengine_search_sqli.rb - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            jsp = %Q|
    <%@page import="java.io.*"%>
    <%@page import="sun.misc.BASE64Decoder"%>

    <%
        Severity: Major
        Found in modules/exploits/multi/http/manageengine_search_sqli.rb and 2 other locations - About 1 hr to fix
        modules/exploits/multi/misc/indesign_server_soap.rb on lines 112..128
        modules/exploits/windows/browser/realplayer_cdda_uri.rb on lines 77..97

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 6 locations. Consider refactoring.
        Open

            if @my_target['Platform'] == 'linux'
      var_proc1 = Rex::Text.rand_text_alpha(rand(8) + 3)
      chmod = %Q|
      Process #{var_proc1} = Runtime.getRuntime().exec("chmod 777 " + #{var_path});
      Thread.sleep(200);
        Severity: Major
        Found in modules/exploits/multi/http/manageengine_search_sqli.rb and 5 other locations - About 55 mins to fix
        modules/exploits/multi/http/eventlog_file_upload.rb on lines 212..226
        modules/exploits/multi/http/manage_engine_dc_pmp_sqli.rb on lines 353..367
        modules/exploits/multi/http/novell_servicedesk_rce.rb on lines 191..205
        modules/exploits/multi/http/sysaid_auth_file_upload.rb on lines 180..194
        modules/exploits/multi/http/webnms_file_upload.rb on lines 149..163

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status