Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/mantisbt_php_exec.rb

Summary

Maintainability
D
3 days
Test Coverage

Method upload_xml has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def upload_xml(payload_b64, rand_text, cookies, is_check)

    if is_check
      timeout = 20
    else
Severity: Major
Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 4 hrs to fix

    File mantisbt_php_exec.rb has 301 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = GreatRanking

  include Msf::Exploit::Remote::HttpClient
  include REXML
    Severity: Minor
    Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 3 hrs to fix

      Method exec_php has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def exec_php(php_code, is_check = false)
    print_status('Checking access to MantisBT...')
    res = send_request_cgi({
      'method'   => 'GET',
      'uri'      => normalize_uri(target_uri.path)
      Severity: Major
      Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 2 hrs to fix

        Method exec_php has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

          def exec_php(php_code, is_check = false)
    print_status('Checking access to MantisBT...')
    res = send_request_cgi({
      'method'   => 'GET',
      'uri'      => normalize_uri(target_uri.path)
        Severity: Minor
        Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method upload_xml has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

          def upload_xml(payload_b64, rand_text, cookies, is_check)

    if is_check
      timeout = 20
    else
        Severity: Minor
        Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info = {})
    super(update_info(info,
      'Name'           => 'MantisBT XmlImportExport Plugin PHP Code Injection Vulnerability',
      'Description'    => %q{
        This module exploits a post-auth vulnerability found in MantisBT versions 1.2.0a3 up to 1.2.17 when the Import/Export plugin is installed.
        Severity: Minor
        Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 1 hr to fix

          Method do_login has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def do_login()
    # check for anonymous login
    res = send_request_cgi({
      'method'   => 'GET',
      'uri'      => normalize_uri(target_uri.path, 'login_anon.php')
          Severity: Minor
          Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 1 hr to fix

            Method get_mantis_version has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def get_mantis_version
    xml = Document.new
    xml.add_element(
    "soapenv:Envelope",
    {
            Severity: Minor
            Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 1 hr to fix

              Method do_login has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def do_login()
    # check for anonymous login
    res = send_request_cgi({
      'method'   => 'GET',
      'uri'      => normalize_uri(target_uri.path, 'login_anon.php')
              Severity: Minor
              Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                    return false
              Severity: Major
              Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return true
                Severity: Major
                Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return false
                  Severity: Major
                  Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return false
                    Severity: Major
                    Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return true
                      Severity: Major
                      Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                              return false
                        Severity: Major
                        Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return false
                          Severity: Major
                          Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                  return res_payload
                            Severity: Major
                            Found in modules/exploits/multi/http/mantisbt_php_exec.rb - About 30 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  xml_file =   %Q|
    <mantis version="1.2.17" urlbase="http://localhost/" issuelink="${eval(base64_decode(#{ payload_b64 }))}}" notelink="~" format="1">
        <issue>
            <id>#{ rand_num }</id>
            <project id="#{ project_id }">#{ rand_text }</project>
                              Severity: Minor
                              Found in modules/exploits/multi/http/mantisbt_php_exec.rb and 1 other location - About 1 hr to fix
                              modules/exploits/windows/browser/ibm_spss_c1sizer.rb on lines 299..314

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 47.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status