Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/maracms_upload_exec.rb

Summary

Maintainability
D
1 day
Test Coverage

Method initialize has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'MaraCMS Arbitrary PHP File Upload',
Severity: Major
Found in modules/exploits/multi/http/maracms_upload_exec.rb - About 3 hrs to fix

    Method login has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def login
    # visit login page in order to obtain `shash` value, which is necessary for authentication
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path),
    Severity: Major
    Found in modules/exploits/multi/http/maracms_upload_exec.rb - About 2 hrs to fix

      Method login has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

        def login
    # visit login page in order to obtain `shash` value, which is necessary for authentication
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path),
      Severity: Minor
      Found in modules/exploits/multi/http/maracms_upload_exec.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method upload_payload has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def upload_payload
    # set payload according to target platform
    if target['Platform'] == 'php'
      pl = payload.encoded
    else
      Severity: Minor
      Found in modules/exploits/multi/http/maracms_upload_exec.rb - About 1 hr to fix

        Method upload_payload has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def upload_payload
    # set payload according to target platform
    if target['Platform'] == 'php'
      pl = payload.encoded
    else
        Severity: Minor
        Found in modules/exploits/multi/http/maracms_upload_exec.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    vprint_status('Running check')

    # visit /about.php to obtain MaraCMS version and cookies
    res = send_request_cgi({
        Severity: Minor
        Found in modules/exploits/multi/http/maracms_upload_exec.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return CheckCode::Appears('Target is most likely MaraCMS with version 7.5 or lower')
        Severity: Major
        Found in modules/exploits/multi/http/maracms_upload_exec.rb - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                        'Arch' => [ARCH_PHP],
              'Platform' => 'php',
              'DefaultOptions' => {
                'PAYLOAD' => 'php/meterpreter/reverse_tcp'
              }
          Severity: Minor
          Found in modules/exploits/multi/http/maracms_upload_exec.rb and 1 other location - About 45 mins to fix
          modules/exploits/multi/http/horizontcms_upload_exec.rb on lines 56..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 39.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status