Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/mediawiki_syntaxhighlight.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method login has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def login
    print_status("Trying to login....")
    # get login token
    res = send_request_cgi({
      'method' => 'POST',
Severity: Minor
Found in modules/exploits/multi/http/mediawiki_syntaxhighlight.rb - About 1 hr to fix

    Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name' => 'MediaWiki SyntaxHighlight extension option injection vulnerability',
      'Description'    => %q{
        This module exploits an option injection vulnerability in the SyntaxHighlight
    Severity: Minor
    Found in modules/exploits/multi/http/mediawiki_syntaxhighlight.rb - About 1 hr to fix

      Method exploit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def exploit
    @cookie = ''
    if datastore['USERNAME'] && datastore['USERNAME'].length > 0
      login
    end
      Severity: Minor
      Found in modules/exploits/multi/http/mediawiki_syntaxhighlight.rb - About 1 hr to fix

        Method login has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def login
    print_status("Trying to login....")
    # get login token
    res = send_request_cgi({
      'method' => 'POST',
        Severity: Minor
        Found in modules/exploits/multi/http/mediawiki_syntaxhighlight.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
    @cookie = ''
    if datastore['USERNAME'] && datastore['USERNAME'].length > 0
      login
    end
        Severity: Minor
        Found in modules/exploits/multi/http/mediawiki_syntaxhighlight.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status