Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/moodle_admin_shell_upload.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Moodle Admin Shell Upload',
Severity: Minor
Found in modules/exploits/multi/http/moodle_admin_shell_upload.rb - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      def create_addon_file
    # There are syntax errors in creating zip file. So the payload was sent as base64.
    plugin_file = Rex::Zip::Archive.new
    header = Rex::Text.rand_text_alpha_upper(4)
    plugin_name = Rex::Text.rand_text_alpha_lower(8)
    Severity: Major
    Found in modules/exploits/multi/http/moodle_admin_shell_upload.rb and 1 other location - About 1 hr to fix
    modules/exploits/multi/http/moodle_teacher_enrollment_priv_esc_to_rce.rb on lines 130..144

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def check
    v = moodle_version
    return CheckCode::Detected('Unable to determine moodle version') if v.nil?

    # This is a feature, not a vuln, so we assume this to work on 3.0.0+
    Severity: Minor
    Found in modules/exploits/multi/http/moodle_admin_shell_upload.rb and 1 other location - About 35 mins to fix
    modules/exploits/osx/local/feedback_assistant_root.rb on lines 56..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      def exec_code(plugin_name, header)
    # Base64 was encoded in "PHP". This process was sent as "HTTP headers".
    print_status('Triggering payload')
    send_request_cgi({
      'keep_cookies' => true,
    Severity: Minor
    Found in modules/exploits/multi/http/moodle_admin_shell_upload.rb and 1 other location - About 30 mins to fix
    modules/exploits/multi/http/moodle_teacher_enrollment_priv_esc_to_rce.rb on lines 148..154

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status