Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/moodle_spelling_path_rce.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Moodle SpellChecker Path Authenticated Remote Command Execution',
Severity: Minor
Found in modules/exploits/multi/http/moodle_spelling_path_rce.rb - About 1 hr to fix

    Method change_aspellpath has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def change_aspellpath(value = '')
    res = send_request_cgi({
      'uri' => normalize_uri(target_uri.path, 'admin', 'settings.php'),
      'vars_get' =>
        {
    Severity: Minor
    Found in modules/exploits/multi/http/moodle_spelling_path_rce.rb - About 1 hr to fix

      Method set_spellchecker has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def set_spellchecker(checker = '')
    # '' is None in the gui, and is the default
    res = send_request_cgi({
      'uri' => normalize_uri(target_uri.path, 'admin', 'settings.php'),
      'vars_get' =>
      Severity: Minor
      Found in modules/exploits/multi/http/moodle_spelling_path_rce.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def check
    return CheckCode::Unknown('No web server or moodle instance found') unless moodle_and_online?

    v = moodle_version
    return CheckCode::Detected('Unable to determine moodle version') if v.nil?
        Severity: Minor
        Found in modules/exploits/multi/http/moodle_spelling_path_rce.rb and 1 other location - About 45 mins to fix
        modules/exploits/multi/http/moodle_spelling_binary_rce.rb on lines 73..82

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status