Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/mybb_rce_cve_2022_24734.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'MyBB Admin Control Code Injection RCE',
Severity: Major
Found in modules/exploits/multi/http/mybb_rce_cve_2022_24734.rb - About 3 hrs to fix

    Method send_payload has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def send_payload(cmd)
    vprint_status('Adding a crafted configuration setting entry with the payload')

    cmd = cmd.gsub(/\\/, '\\' => '\\\\')
    cmd = cmd.gsub(/"/, '"' => '\\"')
    Severity: Minor
    Found in modules/exploits/multi/http/mybb_rce_cve_2022_24734.rb - About 1 hr to fix

      Method send_payload has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def send_payload(cmd)
    vprint_status('Adding a crafted configuration setting entry with the payload')

    cmd = cmd.gsub(/\\/, '\\' => '\\\\')
    cmd = cmd.gsub(/"/, '"' => '\\"')
      Severity: Minor
      Found in modules/exploits/multi/http/mybb_rce_cve_2022_24734.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method send_config_settings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def send_config_settings(method: 'GET', action: 'add', vars_get: {}, vars_post: {}, check_response: true)
    req_hash = {
      'uri' => normalize_uri(target_uri.path, '/admin/index.php'),
      'method' => method,
      'vars_get' => {
      Severity: Minor
      Found in modules/exploits/multi/http/mybb_rce_cve_2022_24734.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status