Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/php_fpm_rce.rb

Summary

Maintainability
D
2 days
Test Coverage

File php_fpm_rce.rb has 389 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote

  Rank = NormalRanking

  include Msf::Exploit::Remote::HttpClient
Severity: Minor
Found in modules/exploits/multi/http/php_fpm_rce.rb - About 5 hrs to fix

    Method initialize has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'PHP-FPM Underflow RCE',
    Severity: Major
    Found in modules/exploits/multi/http/php_fpm_rce.rb - About 3 hrs to fix

      Method check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    print_status('Sending baseline query...')
    res = send_crafted_request(path: "/path\ninfo.php")
    return CheckCode::Unknown('Error when sending baseline query') unless res
      Severity: Minor
      Found in modules/exploits/multi/http/php_fpm_rce.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    print_status('Sending baseline query...')
    res = send_crafted_request(path: "/path\ninfo.php")
    return CheckCode::Unknown('Error when sending baseline query') unless res
      Severity: Minor
      Found in modules/exploits/multi/http/php_fpm_rce.rb - About 1 hr to fix

        Method send_crafted_request has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def send_crafted_request(path:, qsl: datastore['MinQSL'], customh_length: 1, cmd: '', allow_retry: true)
    uri = Rex::Text.uri_encode(normalize_uri(target_uri.path, path)).gsub(/([?&])/, { '?' => '%3F', '&' => '%26' })
    qsl_delta = uri.length - path.length - Rex::Text.uri_encode(target_uri.path).length
    if qsl_delta.odd?
      fail_with Failure::Unknown, "Got odd qslDelta, that means the URL encoding gone wrong: path=#{path}, qsl_delta=#{qsl_delta}"
        Severity: Minor
        Found in modules/exploits/multi/http/php_fpm_rce.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method send_crafted_request has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def send_crafted_request(path:, qsl: datastore['MinQSL'], customh_length: 1, cmd: '', allow_retry: true)
    uri = Rex::Text.uri_encode(normalize_uri(target_uri.path, path)).gsub(/([?&])/, { '?' => '%3F', '&' => '%26' })
    qsl_delta = uri.length - path.length - Rex::Text.uri_encode(target_uri.path).length
    if qsl_delta.odd?
      fail_with Failure::Unknown, "Got odd qslDelta, that means the URL encoding gone wrong: path=#{path}, qsl_delta=#{qsl_delta}"
        Severity: Minor
        Found in modules/exploits/multi/http/php_fpm_rce.rb - About 1 hr to fix

          Method sanity_check? has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def sanity_check?
    datastore['OperationMaxRetries'].times do
      res = send_crafted_request(
        path: "/PHP\nSOSAT",
        qsl: datastore['MaxQSL'],
          Severity: Minor
          Found in modules/exploits/multi/http/php_fpm_rce.rb - About 1 hr to fix

            Method send_attack_chain has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def send_attack_chain
    [
      'short_open_tag=1',
      'html_errors=0',
      'include_path=/tmp',
            Severity: Minor
            Found in modules/exploits/multi/http/php_fpm_rce.rb - About 1 hr to fix

              Method sanity_check? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def sanity_check?
    datastore['OperationMaxRetries'].times do
      res = send_crafted_request(
        path: "/PHP\nSOSAT",
        qsl: datastore['MaxQSL'],
              Severity: Minor
              Found in modules/exploits/multi/http/php_fpm_rce.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method send_params_detection has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def send_params_detection(qsl_candidates:, customh_length:, detect_method:)
    php_setting = detect_method.php_option_enable
    vprint_status("Iterating until the PHP option is enabled (#{php_setting})...")
    customh_lengths = customh_length ? [customh_length] : (1..datastore['MaxCustomHeaderLength']).to_a
    qsl_candidates.product(customh_lengths) do |qsl, c_length|
              Severity: Minor
              Found in modules/exploits/multi/http/php_fpm_rce.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def exploit
    unless check == CheckCode::Vulnerable
      fail_with Failure::NotVulnerable, 'Target is not vulnerable.'
    end
    if @params[:qsl].nil? || @params[:customh_length].nil?
              Severity: Minor
              Found in modules/exploits/multi/http/php_fpm_rce.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                  return CheckCode::Detected('Unable to detect parameters') unless @params
              Severity: Major
              Found in modules/exploits/multi/http/php_fpm_rce.rb - About 30 mins to fix

                Method detect_qsl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def detect_qsl
    qsl_candidates = []
    (datastore['MinQSL']..datastore['MaxQSL']).step(datastore['QSLDetectStep']) do |qsl|
      res = send_crafted_request(path: "/PHP\nabcdefghijklmopqrstuv.php", qsl: qsl)
      unless res
                Severity: Minor
                Found in modules/exploits/multi/http/php_fpm_rce.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method send_attack_chain has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def send_attack_chain
    [
      'short_open_tag=1',
      'html_errors=0',
      'include_path=/tmp',
                Severity: Minor
                Found in modules/exploits/multi/http/php_fpm_rce.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status