Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/phpmyadmin_preg_replace.rb

Summary

Maintainability
C
1 day
Test Coverage

Method check has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def check
    begin
      res = send_request_cgi({ 'uri' => normalize_uri(target_uri.path, '/js/messages.php') })
    rescue
      vprint_error("Unable to connect to server.")
Severity: Minor
Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploit has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    # Always display target info
    print_status(check[1])

    uri = target_uri.path
Severity: Major
Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 2 hrs to fix

    Method initialize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name' => 'phpMyAdmin Authenticated Remote Code Execution via preg_replace()',
      'Description' => %q{
          This module exploits a PREG_REPLACE_EVAL vulnerability in phpMyAdmin's
    Severity: Minor
    Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 1 hr to fix

      Method check has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    begin
      res = send_request_cgi({ 'uri' => normalize_uri(target_uri.path, '/js/messages.php') })
    rescue
      vprint_error("Unable to connect to server.")
      Severity: Minor
      Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 1 hr to fix

        Method exploit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
    # Always display target info
    print_status(check[1])

    uri = target_uri.path
        Severity: Minor
        Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                  return CheckCode::Safe
        Severity: Major
        Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                        return CheckCode::Safe
          Severity: Major
          Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return CheckCode::Appears
            Severity: Major
            Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return CheckCode::Appears
              Severity: Major
              Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return CheckCode::Detected
                Severity: Major
                Found in modules/exploits/multi/http/phpmyadmin_preg_replace.rb - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status