Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/processmaker_plugin_upload.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method generate_plugin has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def generate_plugin(plugin_name)
    plugin_class = %Q|<?php
      class #{plugin_name}Class extends PMPlugin {
        function __construct() {
          set_include_path(
Severity: Minor
Found in modules/exploits/multi/http/processmaker_plugin_upload.rb - About 1 hr to fix

    Method upload_plugin has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def upload_plugin plugin_name
    data = generate_plugin plugin_name

    print_status "#{peer} Uploading plugin '#{plugin_name}' (#{data.length} bytes)"
    Severity: Minor
    Found in modules/exploits/multi/http/processmaker_plugin_upload.rb - About 1 hr to fix

      Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(info,
      'Name'           => 'ProcessMaker Plugin Upload',
      'Description'    => %q{
        This module will generate and upload a plugin to ProcessMaker
      Severity: Minor
      Found in modules/exploits/multi/http/processmaker_plugin_upload.rb - About 1 hr to fix

        Method login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def login(user, pass)
    vars_post = Hash[{
      'form[USR_USERNAME]' => Rex::Text.uri_encode(user, 'hex-normal'),
      'form[USR_PASSWORD]' => Rex::Text.uri_encode(pass, 'hex-normal')
    }.to_a.shuffle]
        Severity: Minor
        Found in modules/exploits/multi/http/processmaker_plugin_upload.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status