Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/testlink_upload_exec.rb

Summary

Maintainability
D
1 day
Test Coverage

Method exploit has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    base = normalize_uri(target_uri.path)
    base << '/' if base[-1, 1] != '/'

    datastore['COOKIE'] = "PHPSESSID=" + rand_text_alpha_lower(26) + ";"
Severity: Major
Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 4 hrs to fix

    Method exploit has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    base = normalize_uri(target_uri.path)
    base << '/' if base[-1, 1] != '/'

    datastore['COOKIE'] = "PHPSESSID=" + rand_text_alpha_lower(26) + ";"
    Severity: Minor
    Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => "TestLink v1.9.3 Arbitrary File Upload Vulnerability",
    Severity: Minor
    Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 2 hrs to fix

      Method check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    base = target_uri.path
    base << '/' if base[-1, 1] != '/'
    peer = "#{rhost}:#{rport}"
      Severity: Minor
      Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return
        Severity: Major
        Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return Exploit::CheckCode::Safe
          Severity: Major
          Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return
            Severity: Major
            Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return
              Severity: Major
              Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return
                Severity: Major
                Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return
                  Severity: Major
                  Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return Exploit::CheckCode::Unknown
                    Severity: Major
                    Found in modules/exploits/multi/http/testlink_upload_exec.rb - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if client.type == "meterpreter"
      client.core.use("stdapi") if not client.ext.aliases.include?("stdapi")
      client.fs.file.rm("#{@token}.php")
    else
      client.shell_command_token("rm #{@token}.php")
                      Severity: Minor
                      Found in modules/exploits/multi/http/testlink_upload_exec.rb and 1 other location - About 25 mins to fix
                      modules/exploits/multi/http/kordil_edms_upload_exec.rb on lines 99..103

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 31.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status