Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/tomcat_mgr_upload.rb

Summary

Maintainability
D
1 day
Test Coverage

File tomcat_mgr_upload.rb has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  HttpFingerprint = { :pattern => [ /Apache.*(Coyote|Tomcat)/ ] }
Severity: Minor
Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 3 hrs to fix

    Method initialize has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'        => 'Apache Tomcat Manager Authenticated Upload Code Execution',
      'Description' => %q{
        This module can be used to execute a payload on Apache Tomcat servers that
    Severity: Major
    Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 2 hrs to fix

      Method detect_arch has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        def detect_arch(body)
    return nil if body.blank?

    i=0
    body.each_line do |ln|
      Severity: Minor
      Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method detect_platform has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def detect_platform(body)
    return nil if body.blank?

    i=0
      Severity: Minor
      Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method exploit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    @app_base = rand_text_alphanumeric(4 + rand(32 - 4))
    @jsp_name = rand_text_alphanumeric(4 + rand(32 - 4))

    #
      Severity: Minor
      Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    res = query_manager
    disconnect

    return CheckCode::Unknown if res.nil?
      Severity: Minor
      Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                return ARCH_X86
      Severity: Major
      Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  return 'unknown'
        Severity: Major
        Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return CheckCode::Unknown unless plat and arch
          Severity: Major
          Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return CheckCode::Appears
            Severity: Major
            Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return ARCH_X86
              Severity: Major
              Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 30 mins to fix

                Method upload_payload has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def upload_payload
    war = war_payload
    upload_path = normalize_uri(target_uri.path.to_s, "html", "upload")
    vprint_status("Uploading #{war.length} bytes as #{@app_base}.war ...")
    res = send_war_payload(upload_path, war)
                Severity: Minor
                Found in modules/exploits/multi/http/tomcat_mgr_upload.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                          ['CVE', '2009-3843'],
          ['OSVDB', '60317'],
          ['CVE', '2009-4189'],
          ['OSVDB', '60670'],
                Severity: Major
                Found in modules/exploits/multi/http/tomcat_mgr_upload.rb and 4 other locations - About 50 mins to fix
                modules/exploits/apple_ios/browser/webkit_trident.rb on lines 26..39
                modules/exploits/linux/local/glibc_ld_audit_dso_load_priv_esc.rb on lines 61..74
                modules/exploits/multi/http/tomcat_mgr_deploy.rb on lines 36..59
                modules/exploits/windows/fileformat/office_word_hta.rb on lines 37..50

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 43.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status