Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Xorg X11 Server SUID modulepath Privilege Escalation',
Severity: Major
Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb - About 3 hrs to fix

    Method check has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    # linux checks
    uname = cmd_exec('uname')
    if uname =~ /linux/i
      vprint_status 'Running additional check for Linux'
    Severity: Minor
    Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    check_status = check
    if check_status == CheckCode::Appears
      print_warning 'Could not get version or Xorg process possibly running, may fail'
    elsif check_status == CheckCode::Safe
    Severity: Minor
    Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb - About 1 hr to fix

      Method check has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    # linux checks
    uname = cmd_exec('uname')
    if uname =~ /linux/i
      vprint_status 'Running additional check for Linux'
      Severity: Minor
      Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb - About 1 hr to fix

        Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
    check_status = check
    if check_status == CheckCode::Appears
      print_warning 'Could not get version or Xorg process possibly running, may fail'
    elsif check_status == CheckCode::Safe
        Severity: Minor
        Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return CheckCode::Safe
        Severity: Major
        Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return CheckCode::Appears
          Severity: Major
          Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Appears
            Severity: Major
            Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return CheckCode::Vulnerable
              Severity: Major
              Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    register_advanced_options(
      [
        OptString.new('WritableDir', [ true, 'A directory where we can write files', '/tmp' ]),
        OptString.new('Xdisplay', [ true, 'Display exploit will attempt to use', ':1' ]),
        OptBool.new('ConsoleLock', [ true, 'Will check for console lock under linux', true ]),
                Severity: Minor
                Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb and 1 other location - About 25 mins to fix
                modules/auxiliary/scanner/http/squid_pivot_scanning.rb on lines 52..58

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 30.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      if datastore['ConsoleLock']
        user = cmd_exec('id -un')
        unless exist?("/var/run/console/#{user}")
          vprint_error("No console lock for #{user}")
          return CheckCode::Safe
                Severity: Minor
                Found in modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb and 1 other location - About 15 mins to fix
                modules/exploits/multi/local/xorg_x11_suid_server.rb on lines 119..125

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 25.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status