Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/misc/java_rmi_server.rb

Summary

Maintainability
D
1 day
Test Coverage

Method initialize has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Java RMI Server Insecure Default Configuration Java Code Execution',
      'Description'    => %q{
          This module takes advantage of the default configuration of the RMI Registry and
Severity: Major
Found in modules/exploits/multi/misc/java_rmi_server.rb - About 2 hrs to fix

    Method primer has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def primer
    connect

    print_status("Sending RMI Header...")
    send_header
    Severity: Minor
    Found in modules/exploits/multi/misc/java_rmi_server.rb - About 1 hr to fix

      Method build_dgc_clean_args has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def build_dgc_clean_args(jar_url)
    arguments = []

    new_array_annotation = Rex::Java::Serialization::Model::Annotation.new
    new_array_annotation.contents = [
      Severity: Minor
      Found in modules/exploits/multi/misc/java_rmi_server.rb - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          def build_dgc_clean_args(jar_url)
    arguments = []

    new_array_annotation = Rex::Java::Serialization::Model::Annotation.new
    new_array_annotation.contents = [
        Severity: Major
        Found in modules/exploits/multi/misc/java_rmi_server.rb and 1 other location - About 6 hrs to fix
        modules/auxiliary/scanner/misc/java_rmi_server.rb on lines 125..183

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 217.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

                  [ 'Generic (Java Payload)',
            {
              'Platform' => ['java'],
              'Arch' => ARCH_JAVA
            }
        Severity: Major
        Found in modules/exploits/multi/misc/java_rmi_server.rb and 4 other locations - About 40 mins to fix
        modules/exploits/multi/browser/java_atomicreferencearray.rb on lines 48..77
        modules/exploits/multi/browser/java_calendar_deserialize.rb on lines 43..72
        modules/exploits/multi/browser/java_signed_applet.rb on lines 45..74
        modules/exploits/multi/browser/java_verifier_field_access.rb on lines 48..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status