Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/misc/nomad_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method check has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def check
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, '/v1/agent/self'),
      'headers' => {
Severity: Minor
Found in modules/exploits/multi/misc/nomad_exec.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute_command has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def execute_command(cmd, _opts = {})
    uri = target_uri.path
    job_name = datastore['JOB_NAME'] == '' ? Rex::Text.rand_text_alpha(5..10) : datastore['JOB_NAME']
    print_status("Creating job '#{job_name}'")
Severity: Major
Found in modules/exploits/multi/misc/nomad_exec.rb - About 2 hrs to fix

    Method initialize has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'HashiCorp Nomad Remote Command Execution',
    Severity: Major
    Found in modules/exploits/multi/misc/nomad_exec.rb - About 2 hrs to fix

      Method check has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, '/v1/agent/self'),
      'headers' => {
      Severity: Minor
      Found in modules/exploits/multi/misc/nomad_exec.rb - About 1 hr to fix

        Method execute_command has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def execute_command(cmd, _opts = {})
    uri = target_uri.path
    job_name = datastore['JOB_NAME'] == '' ? Rex::Text.rand_text_alpha(5..10) : datastore['JOB_NAME']
    print_status("Creating job '#{job_name}'")
        Severity: Minor
        Found in modules/exploits/multi/misc/nomad_exec.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return CheckCode::Unknown
        Severity: Major
        Found in modules/exploits/multi/misc/nomad_exec.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return CheckCode::Appears
          Severity: Major
          Found in modules/exploits/multi/misc/nomad_exec.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Vulnerable
            Severity: Major
            Found in modules/exploits/multi/misc/nomad_exec.rb - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status