Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/misc/openview_omniback_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method check has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check

    if (target.name =~ /Unix/)
      connect
Severity: Major
Found in modules/exploits/multi/misc/openview_omniback_exec.rb - About 2 hrs to fix

    Method exploit has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    if (target.name =~ /Unix/)
      connect

      poof =
    Severity: Major
    Found in modules/exploits/multi/misc/openview_omniback_exec.rb - About 2 hrs to fix

      Method initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(info,
      'Name'           => 'HP OpenView OmniBack II Command Execution',
      'Description'    => %q{
          This module uses a vulnerability in the OpenView Omniback II
      Severity: Minor
      Found in modules/exploits/multi/misc/openview_omniback_exec.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def check

    if (target.name =~ /Unix/)
      connect
        Severity: Minor
        Found in modules/exploits/multi/misc/openview_omniback_exec.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def exploit
    if (target.name =~ /Unix/)
      connect

      poof =
        Severity: Minor
        Found in modules/exploits/multi/misc/openview_omniback_exec.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return Exploit::CheckCode::Vulnerable
        Severity: Major
        Found in modules/exploits/multi/misc/openview_omniback_exec.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return Exploit::CheckCode::Safe
          Severity: Major
          Found in modules/exploits/multi/misc/openview_omniback_exec.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status