Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb

Summary

Maintainability
F
4 days
Test Coverage

File teamcity_agent_xmlrpc_exec.rb has 673 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::CmdStager
Severity: Major
Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 1 day to fix

    Method req_teamcity_2017 has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def req_teamcity_2017(script_content)
    build_code = Rex::Text.rand_text_alpha(8)
    build_id = Rex::Text.rand_text_numeric(8)
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
    Severity: Major
    Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 2 hrs to fix

      Method req_teamcity_7 has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def req_teamcity_7(script_content)
    build_id = Rex::Text.rand_text_numeric(8)
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
<methodCall>
      Severity: Major
      Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 2 hrs to fix

        Method req_teamcity_10 has 73 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def req_teamcity_10(script_content)
    build_code = Rex::Text.rand_text_alpha(8)
    build_id = Rex::Text.rand_text_numeric(8)
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
        Severity: Major
        Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 2 hrs to fix

          Method req_teamcity_8 has 70 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def req_teamcity_8(script_content)
    build_id = Rex::Text.rand_text_numeric(8)
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
<methodCall>
          Severity: Major
          Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 2 hrs to fix

            Method req_teamcity_9 has 69 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def req_teamcity_9(script_content)
    build_id = Rex::Text.rand_text_numeric(8)
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
<methodCall>
            Severity: Major
            Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 2 hrs to fix

              Method req_teamcity_6_5 has 63 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def req_teamcity_6_5(script_content)
    build_id = Rex::Text.rand_text_numeric(8)
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
<methodCall>
              Severity: Major
              Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 2 hrs to fix

                Method req_teamcity_6 has 62 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def req_teamcity_6(script_content)
    build_id = Rex::Text.rand_text_numeric(8)
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
<methodCall>
                Severity: Major
                Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 2 hrs to fix

                  Method initialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def initialize(info = {})
    super(update_info(info,
      'Name'           => 'TeamCity Agent XML-RPC Command Execution',
      'Description'    => %q(
        This module allows remote code execution on TeamCity Agents configured
                  Severity: Minor
                  Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 1 hr to fix

                    Method determine_version has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      def determine_version
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
<methodCall>
  <methodName>buildAgent.getVersion</methodName>
                    Severity: Minor
                    Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 1 hr to fix

                      Method determine_version has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def determine_version
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
<methodCall>
  <methodName>buildAgent.getVersion</methodName>
                      Severity: Minor
                      Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid too many return statements within this method.
                      Open

                            return req_teamcity_10(script_content)
                      Severity: Major
                      Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                              return req_teamcity_8(script_content)
                        Severity: Major
                        Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return req_teamcity_9(script_content)
                          Severity: Major
                          Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                  return req_teamcity_2017(script_content)
                            Severity: Major
                            Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb - About 30 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                def req_teamcity_2017(script_content)
    build_code = Rex::Text.rand_text_alpha(8)
    build_id = Rex::Text.rand_text_numeric(8)
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
                              Severity: Minor
                              Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb and 1 other location - About 15 mins to fix
                              modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb on lines 280..353

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 26.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                def req_teamcity_10(script_content)
    build_code = Rex::Text.rand_text_alpha(8)
    build_id = Rex::Text.rand_text_numeric(8)
    xml_payload = %(
<?xml version="1.0" encoding="UTF-8"?>
                              Severity: Minor
                              Found in modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb and 1 other location - About 15 mins to fix
                              modules/exploits/multi/misc/teamcity_agent_xmlrpc_exec.rb on lines 203..277

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 26.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status