Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/misc/weblogic_deserialize_marshalledobject.rb

Summary

Maintainability
D
3 days
Test Coverage

Method build_t3_request_object has 191 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def build_t3_request_object
    # T3 request serialized data
    # retrieved by watching network traffic
    # This is a proprietary, undocumented protocol
    # TODO: WHAT DOES THIS DO?  CAN WE RANDOMIZE ANY OF IT?
Severity: Major
Found in modules/exploits/multi/misc/weblogic_deserialize_marshalledobject.rb - About 7 hrs to fix

    File weblogic_deserialize_marshalledobject.rb has 452 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Remote
  Rank = ManualRanking

  include Msf::Exploit::Remote::Tcp
  include Msf::Exploit::JavaDeserialization
    Severity: Minor
    Found in modules/exploits/multi/misc/weblogic_deserialize_marshalledobject.rb - About 6 hrs to fix

      Method send_payload_objdata has 131 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def send_payload_objdata
    # basic weblogic ClassTableEntry object (serialized)
    # TODO: WHAT DOES THIS DO?  CAN WE RANDOMIZE ANY OF IT?
    objdata = '056508000000010000001b0000005d0101007372017870737202787000000000'
    objdata << '00000000757203787000000000787400087765626c6f67696375720478700000'
      Severity: Major
      Found in modules/exploits/multi/misc/weblogic_deserialize_marshalledobject.rb - About 5 hrs to fix

        Method initialize has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info={})
    super(update_info(info,
      'Name' => 'Oracle Weblogic Server Deserialization RCE - MarshalledObject',
      'Description' => %q{
        An unauthenticated attacker with network access to the Oracle Weblogic Server T3
        Severity: Major
        Found in modules/exploits/multi/misc/weblogic_deserialize_marshalledobject.rb - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                    [ 'Unix',
            'Platform' => 'unix',
            'Arch' => ARCH_CMD,
            'DefaultOptions' => {'PAYLOAD' => 'cmd/unix/reverse_python'},
            'Payload' => {
          Severity: Major
          Found in modules/exploits/multi/misc/weblogic_deserialize_marshalledobject.rb and 1 other location - About 1 hr to fix
          modules/exploits/multi/misc/weblogic_deserialize_rawobject.rb on lines 37..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def t3_handshake
    # retrieved from network traffic
    if !datastore['SSL'] || datastore['FORCE_T3']
      shake = 't3'
    else
          Severity: Minor
          Found in modules/exploits/multi/misc/weblogic_deserialize_marshalledobject.rb and 1 other location - About 35 mins to fix
          modules/exploits/multi/misc/weblogic_deserialize_rawobject.rb on lines 119..133

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status