Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/upnp/libupnp_ssdp_overflow.rb

Summary

Maintainability
C
1 day
Test Coverage

File libupnp_ssdp_overflow.rb has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = NormalRanking

  def initialize(info = {})
    super(update_info(info,
Severity: Minor
Found in modules/exploits/multi/upnp/libupnp_ssdp_overflow.rb - About 2 hrs to fix

    Method initialize has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Portable UPnP SDK unique_service_name() Remote Code Execution',
      'Description'    => %q{
          This module exploits a buffer overflow in the unique_service_name()
    Severity: Major
    Found in modules/exploits/multi/upnp/libupnp_ssdp_overflow.rb - About 2 hrs to fix

      Method choose_target has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def choose_target
    # If the user specified a target, use that one
    return self.target unless self.target.name =~ /Automatic/

    msearch =
      Severity: Minor
      Found in modules/exploits/multi/upnp/libupnp_ssdp_overflow.rb - About 1 hr to fix

        Method choose_target has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def choose_target
    # If the user specified a target, use that one
    return self.target unless self.target.name =~ /Automatic/

    msearch =
        Severity: Minor
        Found in modules/exploits/multi/upnp/libupnp_ssdp_overflow.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method cleanup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def cleanup
    super
    if self.service
      print_status("Shutting down payload stager listener...")
      begin
        Severity: Minor
        Found in modules/exploits/multi/upnp/libupnp_ssdp_overflow.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          def cleanup
    super
    if self.service
      print_status("Shutting down payload stager listener...")
      begin
        Severity: Major
        Found in modules/exploits/multi/upnp/libupnp_ssdp_overflow.rb and 3 other locations - About 45 mins to fix
        modules/exploits/linux/http/panos_readsessionvars.rb on lines 190..202
        modules/exploits/unix/misc/polycom_hdx_auth_bypass.rb on lines 228..240
        modules/exploits/unix/misc/polycom_hdx_traceroute_exec.rb on lines 159..171

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status