Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/vpn/tincd_bof.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Tincd Post-Authentication Remote TCP Stack Buffer Overflow',
      'Description'    => %q{
        This module exploits a stack buffer overflow in Tinc's tincd
Severity: Major
Found in modules/exploits/multi/vpn/tincd_bof.rb - About 2 hrs to fix

    Method exploit has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    # #
    # x86
    # #
    # WINDOWS XP and 7 full exploitation
    Severity: Minor
    Found in modules/exploits/multi/vpn/tincd_bof.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    # #
    # x86
    # #
    # WINDOWS XP and 7 full exploitation
    Severity: Major
    Found in modules/exploits/multi/vpn/tincd_bof.rb - About 2 hrs to fix

      Method create_fedora_rop has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create_fedora_rop(sys_execv_args)
    # Gadgets tincd
    loc_dot_data = 0x80692e0 # a location inside .data
    pop_eax = [0x8065969].pack('V') # pop eax; ret
    pop_ebx = [0x8049d8d].pack('V') # pop ebx; ret
      Severity: Major
      Found in modules/exploits/multi/vpn/tincd_bof.rb - About 2 hrs to fix

        Method create_pidora_rop has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def create_pidora_rop(sys_execv_args)
    sys_execv_args = sys_execv_args.join(' ')
    sys_execv_args += "\x00"

    aslr_byte_guess = SecureRandom.random_bytes(1).ord
        Severity: Minor
        Found in modules/exploits/multi/vpn/tincd_bof.rb - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status