Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/osx/local/vmware_fusion_lpe.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'VMware Fusion USB Arbitrator Setuid Privilege Escalation',
Severity: Minor
Found in modules/exploits/osx/local/vmware_fusion_lpe.rb - About 1 hr to fix

    Method exactly_11_5_3 has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exactly_11_5_3
    # Upload payload executable & chmod
    payload_name = "#{base_dir}#{rand_text_alphanumeric(5..10)}"
    print_status "Uploading Payload to #{payload_name}"
    write_file payload_name, generate_payload_exe
    Severity: Minor
    Found in modules/exploits/osx/local/vmware_fusion_lpe.rb - About 1 hr to fix

      Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    if !datastore['ForceExploit'] && is_root?
      fail_with(Failure::BadConfig, 'Session already has root privileges. Set ForceExploit to override.')
    end
      Severity: Minor
      Found in modules/exploits/osx/local/vmware_fusion_lpe.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status