Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/solaris/samba/lsa_transnames_heap.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  def lsa_open_policy(dcerpc, server="\\")
    stubdata =
      # Server
      NDR.uwstring(server) +
      # Object Attributes
Severity: Major
Found in modules/exploits/solaris/samba/lsa_transnames_heap.rb and 3 other locations - About 1 hr to fix
lib/msf/core/exploit/remote/dcerpc_lsa.rb on lines 13..34
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 322..343
modules/exploits/osx/samba/lsa_transnames_heap.rb on lines 312..334

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    begin
      # LsarLookupSids
      dcerpc.call(0x0f, stub)
    rescue Rex::Proto::DCERPC::Exceptions::NoResponse, Rex::Proto::SMB::Exceptions::NoReply, ::EOFError
      print_status('Server did not respond, this is expected')
Severity: Major
Found in modules/exploits/solaris/samba/lsa_transnames_heap.rb and 2 other locations - About 1 hr to fix
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 303..316
modules/exploits/osx/samba/lsa_transnames_heap.rb on lines 293..306

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

          ['Solaris 8/9/10 SPARC Samba 3.0.21-3.0.24',
          {
            'Platform'      => 'solaris',
            'Arch'          => [ ARCH_SPARC ],
            'Nops'          => 64 * 1024,
Severity: Major
Found in modules/exploits/solaris/samba/lsa_transnames_heap.rb and 9 other locations - About 15 mins to fix
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 75..84
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 90..99
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 107..116
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 122..131
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 137..146
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 152..161
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 167..176
modules/exploits/solaris/samba/lsa_transnames_heap.rb on lines 43..52
modules/exploits/solaris/samba/lsa_transnames_heap.rb on lines 69..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

          ['Solaris 8/9/10 x86 Samba 3.0.21-3.0.24',
          {
            'Platform'      => 'solaris',
            'Arch'          => [ ARCH_X86 ],
            'Nops'          => 64 * 1024,
Severity: Major
Found in modules/exploits/solaris/samba/lsa_transnames_heap.rb and 9 other locations - About 15 mins to fix
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 75..84
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 90..99
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 107..116
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 122..131
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 137..146
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 152..161
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 167..176
modules/exploits/solaris/samba/lsa_transnames_heap.rb on lines 56..65
modules/exploits/solaris/samba/lsa_transnames_heap.rb on lines 69..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

          ['DEBUG',
          {
            'Platform'      => 'solaris',
            'Arch'          => [ ARCH_X86 ],
            'Nops'          => 64 * 1024,
Severity: Major
Found in modules/exploits/solaris/samba/lsa_transnames_heap.rb and 9 other locations - About 15 mins to fix
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 75..84
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 90..99
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 107..116
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 122..131
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 137..146
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 152..161
modules/exploits/linux/samba/lsa_transnames_heap.rb on lines 167..176
modules/exploits/solaris/samba/lsa_transnames_heap.rb on lines 43..52
modules/exploits/solaris/samba/lsa_transnames_heap.rb on lines 56..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status