Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/ftp/proftpd_modcopy_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'ProFTPD 1.3.5 Mod_Copy Command Execution',
Severity: Major
Found in modules/exploits/unix/ftp/proftpd_modcopy_exec.rb - About 2 hrs to fix

    Method exploit has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    get_arg = rand_text_alphanumeric(5..7)
    payload_name = rand_text_alphanumeric(5..7) + '.php'

    sock = Rex::Socket.create_tcp('PeerHost' => rhost, 'PeerPort' => ftp_port)
    Severity: Minor
    Found in modules/exploits/unix/ftp/proftpd_modcopy_exec.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    get_arg = rand_text_alphanumeric(5..7)
    payload_name = rand_text_alphanumeric(5..7) + '.php'

    sock = Rex::Socket.create_tcp('PeerHost' => rhost, 'PeerPort' => ftp_port)
    Severity: Minor
    Found in modules/exploits/unix/ftp/proftpd_modcopy_exec.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    sock = Rex::Socket.create_tcp('PeerHost' => rhost, 'PeerPort' => ftp_port)

    if sock.nil?
      return CheckCode::Unknown("#{rhost}:#{ftp_port} - Failed to connect to FTP server")
      Severity: Minor
      Found in modules/exploits/unix/ftp/proftpd_modcopy_exec.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    sock = Rex::Socket.create_tcp('PeerHost' => rhost, 'PeerPort' => ftp_port)

    if sock.nil?
      return CheckCode::Unknown("#{rhost}:#{ftp_port} - Failed to connect to FTP server")
      Severity: Minor
      Found in modules/exploits/unix/ftp/proftpd_modcopy_exec.rb - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

              return CheckCode::Appears("#{rhost}:#{ftp_port} - Unauthenticated SITE CPFR command was successful")
        Severity: Major
        Found in modules/exploits/unix/ftp/proftpd_modcopy_exec.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return CheckCode::Safe("#{rhost}:#{ftp_port} - SITE CPFR command requires authentication.")
          Severity: Major
          Found in modules/exploits/unix/ftp/proftpd_modcopy_exec.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status