Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/http/dell_kace_k1000_upload.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Dell KACE K1000 File Upload',
      'Description'    => %q{
          This module exploits a file upload vulnerability in Kace K1000
Severity: Minor
Found in modules/exploits/unix/http/dell_kace_k1000_upload.rb - About 1 hr to fix

    Method check has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    res = send_request_cgi('uri' => normalize_uri('service', 'kbot_upload.php'))
    unless res
      vprint_error('Connection failed')
      return Exploit::CheckCode::Unknown
    Severity: Minor
    Found in modules/exploits/unix/http/dell_kace_k1000_upload.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    # upload payload
    fname = ".#{rand_text_alphanumeric(rand(8) + 5)}.php"
    payload_path = "/kbox/kboxwww/tmp/"
    post_data = "<?php require_once 'KSudoClient.class.php';KSudoClient::RunCommandWait('rm #{payload_path}#{fname};#{payload.encoded}');?>"
    Severity: Minor
    Found in modules/exploits/unix/http/dell_kace_k1000_upload.rb - About 1 hr to fix

      Method exploit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    # upload payload
    fname = ".#{rand_text_alphanumeric(rand(8) + 5)}.php"
    payload_path = "/kbox/kboxwww/tmp/"
    post_data = "<?php require_once 'KSudoClient.class.php';KSudoClient::RunCommandWait('rm #{payload_path}#{fname};#{payload.encoded}');?>"
      Severity: Minor
      Found in modules/exploits/unix/http/dell_kace_k1000_upload.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return Exploit::CheckCode::Safe
      Severity: Major
      Found in modules/exploits/unix/http/dell_kace_k1000_upload.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return Exploit::CheckCode::Detected
        Severity: Major
        Found in modules/exploits/unix/http/dell_kace_k1000_upload.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status