Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/http/pfsense_config_data_exec.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'pfSense Restore RRD Data Command Injection',
Severity: Minor
Found in modules/exploits/unix/http/pfsense_config_data_exec.rb - About 2 hrs to fix

    Method exploit has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exploit
    unless login
      fail_with(Failure::NoAccess, 'Could not obtain the login cookies!')
    end
    Severity: Minor
    Found in modules/exploits/unix/http/pfsense_config_data_exec.rb - About 1 hr to fix

      Method check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    unless login
      return Exploit::CheckCode::Unknown("#{peer} - Could not obtain the login cookies needed to validate the vulnerability!")
    end
      Severity: Minor
      Found in modules/exploits/unix/http/pfsense_config_data_exec.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method exploit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    unless login
      fail_with(Failure::NoAccess, 'Could not obtain the login cookies!')
    end
      Severity: Minor
      Found in modules/exploits/unix/http/pfsense_config_data_exec.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return Exploit::CheckCode::Safe("Patched pfSense version #{version} detected")
      Severity: Major
      Found in modules/exploits/unix/http/pfsense_config_data_exec.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return Exploit::CheckCode::Detected('Unable to get the pfSense version')
        Severity: Major
        Found in modules/exploits/unix/http/pfsense_config_data_exec.rb - About 30 mins to fix

          Method login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def login
    # Skip the login process if we are already logged in.
    return true if @logged_in

    csrf = get_csrf('index.php', 'GET')
          Severity: Minor
          Found in modules/exploits/unix/http/pfsense_config_data_exec.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status