Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/local/netbsd_mail_local.rb

Summary

Maintainability
C
1 day
Test Coverage

Method exploit has 195 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    # lots of this file's format is based on pkexec.rb

    # direct copy of code from exploit-db
    main = %q{
Severity: Major
Found in modules/exploits/unix/local/netbsd_mail_local.rb - About 7 hrs to fix

    File netbsd_mail_local.rb has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Exploit::Local
  Rank = GreatRanking

  include Msf::Post::File
  include Msf::Exploit::FileDropper
    Severity: Minor
    Found in modules/exploits/unix/local/netbsd_mail_local.rb - About 2 hrs to fix

      Method initialize has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'NetBSD mail.local Privilege Escalation',
      Severity: Major
      Found in modules/exploits/unix/local/netbsd_mail_local.rb - About 2 hrs to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            register_options([
      OptString.new('ATRUNPATH', [true, 'Location of atrun binary', '/usr/libexec/atrun']),
      OptString.new('MAILDIR', [true, 'Location of mailboxes', '/var/mail']),
      OptString.new('WritableDir', [ true, 'A directory where we can write files', '/tmp' ]),
      OptInt.new('ListenerTimeout', [true, 'Number of seconds to wait for the exploit', 603])
        Severity: Minor
        Found in modules/exploits/unix/local/netbsd_mail_local.rb and 3 other locations - About 25 mins to fix
        modules/auxiliary/scanner/http/cgit_traversal.rb on lines 34..40
        modules/auxiliary/server/wpad.rb on lines 31..37
        modules/post/osx/gather/password_prompt_spoof.rb on lines 32..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status