Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/sonicwall/sonicwall_xmlrpc_rce.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method check has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def check
    if datastore['WEB_SERVER_PORT']
      port_number = datastore['WEB_SERVER_PORT']
    else
      port_number = datastore['SSL'] ? '443' : '80'
Severity: Minor
Found in modules/exploits/unix/sonicwall/sonicwall_xmlrpc_rce.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info={})
    super(update_info(info,
      'Name' => "SonicWall Global Management System XMLRPC set_time_zone Unauth RCE",
      'Description' => %q{
        This module exploits a vulnerability in SonicWall Global
Severity: Minor
Found in modules/exploits/unix/sonicwall/sonicwall_xmlrpc_rce.rb - About 1 hr to fix

    Method send_xml has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def send_xml
    xml_body = <<~HERESTRING
    <?xml version="1.0" encoding="UTF-8"?>
    <methodCall>
      <methodName>set_time_config</methodName>
    Severity: Minor
    Found in modules/exploits/unix/sonicwall/sonicwall_xmlrpc_rce.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status