Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(
      info,
      'Name'            => "ActualAnalyzer 'ant' Cookie Command Execution",
      'Description'     => %q{
Severity: Minor
Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 1 hr to fix

    Method get_analytics_host_admin has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_analytics_host_admin
    analytics_host = nil
    user = datastore['USERNAME']
    pass = datastore['PASSWORD']
    res = send_request_cgi(
    Severity: Minor
    Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 1 hr to fix

      Method check has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    # check for aa.php
    res = send_request_raw('uri' => normalize_uri(target_uri.path, 'aa.php'))
    if !res
      vprint_error("Connection failed")
      Severity: Minor
      Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 1 hr to fix

        Method get_analytics_host_view has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def get_analytics_host_view
    analytics_host = nil
    res = send_request_cgi(
      'method' => 'POST',
      'uri' => normalize_uri(target_uri.path, 'view.php'),
        Severity: Minor
        Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 1 hr to fix

          Method exploit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def exploit
    return unless check == Exploit::CheckCode::Vulnerable
    analytics_hosts = []
    if datastore['ANALYZER_HOST'].blank?
      analytics_hosts << get_analytics_host_code
          Severity: Minor
          Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method check has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def check
    # check for aa.php
    res = send_request_raw('uri' => normalize_uri(target_uri.path, 'aa.php'))
    if !res
      vprint_error("Connection failed")
          Severity: Minor
          Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return Exploit::CheckCode::Vulnerable
          Severity: Major
          Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return Exploit::CheckCode::Detected
            Severity: Major
            Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return Exploit::CheckCode::Detected
              Severity: Major
              Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 30 mins to fix

                Method execute_command has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def execute_command(cmd, opts = { analytics_host: vhost })
    vuln_cookies = %w(anw anm)
    res = send_request_cgi(
      'uri' => normalize_uri(target_uri.path, 'aa.php'),
      'vars_get' => { 'anp' => opts[:analytics_host] },
                Severity: Minor
                Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      'vars_post' => {
        'id_h' => '',
        'listp' => '',
        'act_h' => 'vis_int',
        'oldact' => 'vis_grpg',
                Severity: Minor
                Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb and 1 other location - About 25 mins to fix
                modules/post/osx/gather/enum_osx.rb on lines 118..133

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 31.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    register_options(
      [
        OptString.new('TARGETURI', [true, 'The base path to ActualAnalyzer', '/lite/']),
        OptString.new('USERNAME', [true, 'The username for ActualAnalyzer', 'admin']),
        OptString.new('PASSWORD', [true, 'The password for ActualAnalyzer', 'admin']),
                Severity: Minor
                Found in modules/exploits/unix/webapp/actualanalyzer_ant_cookie_exec.rb and 3 other locations - About 25 mins to fix
                modules/auxiliary/scanner/http/cisco_firepower_download.rb on lines 38..45
                modules/exploits/multi/fileformat/visual_studio_vsix_exec.rb on lines 53..58
                modules/exploits/multi/http/atutor_upload_traversal.rb on lines 89..94

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 30.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status