Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/webapp/bolt_authenticated_rce.rb

Summary

Maintainability
D
3 days
Test Coverage

Method check has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def check
    # obtain token and cookie required for login
    res = send_request_cgi 'uri' => normalize_uri(target_uri.path, 'bolt', 'login')

    return CheckCode::Unknown('Connection failed') unless res
Severity: Minor
Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File bolt_authenticated_rce.rb has 316 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote

  Rank = GreatRanking

  include Msf::Exploit::Remote::HttpClient
Severity: Minor
Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 3 hrs to fix

    Method initialize has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Bolt CMS 3.7.0 - Authenticated Remote Code Execution',
    Severity: Major
    Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 3 hrs to fix

      Method check has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    # obtain token and cookie required for login
    res = send_request_cgi 'uri' => normalize_uri(target_uri.path, 'bolt', 'login')

    return CheckCode::Unknown('Connection failed') unless res
      Severity: Major
      Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 2 hrs to fix

        Method try_tokens has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def try_tokens(file_tokens)
    # create .php files and check if any of them can be used for RCE via the username $_GET variable
    file_tokens.each do |token|
      file_path = datastore['FILE_TRAVERSAL_PATH'].chomp('/') # remove trailing `/` in case present
      file_name = Rex::Text.rand_text_alpha_lower(8..12)
        Severity: Minor
        Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method try_tokens has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def try_tokens(file_tokens)
    # create .php files and check if any of them can be used for RCE via the username $_GET variable
    file_tokens.each do |token|
      file_path = datastore['FILE_TRAVERSAL_PATH'].chomp('/') # remove trailing `/` in case present
      file_name = Rex::Text.rand_text_alpha_lower(8..12)
        Severity: Minor
        Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 1 hr to fix

          Method cleanup has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def cleanup
    super

    # delete rogue .php file used for execution (if present)
    delete_file(@rogue_file) if @rogue_file
          Severity: Minor
          Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 1 hr to fix

            Method exploit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def exploit
    csrf
    unless @csrf_token && !@csrf_token.empty?
      fail_with Failure::NoAccess, 'Failed to obtain CSRF token'
    end
            Severity: Minor
            Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cleanup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def cleanup
    super

    # delete rogue .php file used for execution (if present)
    delete_file(@rogue_file) if @rogue_file
            Severity: Minor
            Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method obtain_cache_tokens has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def obtain_cache_tokens
    # obtain tokens for creating rogue .php files from cache
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'async', 'browse', 'cache', '.sessions'),
            Severity: Minor
            Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Unknown('Failed to authenticate to the server.')
            Severity: Major
            Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return CheckCode::Unknown('Connection failed') unless res
              Severity: Major
              Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return CheckCode::Unknown('Connection failed') unless res
                Severity: Major
                Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return CheckCode::Unknown('Authentication failure.')
                  Severity: Major
                  Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return unless @cookie
                    Severity: Major
                    Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                          return CheckCode::Unknown('Connection failed') unless res
                      Severity: Major
                      Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                              return CheckCode::Unknown('Authentication failure.')
                        Severity: Major
                        Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb - About 30 mins to fix

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                                      'Linux (x86)', {
              'Arch' => ARCH_X86,
              'Platform' => 'linux',
              'DefaultOptions' => {
                'PAYLOAD' => 'linux/x86/meterpreter/reverse_tcp'
                          Severity: Major
                          Found in modules/exploits/unix/webapp/bolt_authenticated_rce.rb and 4 other locations - About 35 mins to fix
                          modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb on lines 52..72
                          modules/exploits/linux/http/klog_server_authenticate_user_unauth_command_injection.rb on lines 56..81
                          modules/exploits/linux/http/mida_solutions_eframework_ajaxreq_rce.rb on lines 44..69
                          modules/exploits/multi/misc/msf_rpc_console.rb on lines 34..44

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 34.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status