Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/webapp/drupal_restws_unserialize.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'               => 'Drupal RESTful Web Services unserialize() RCE',
      'Description'        => %q{
        This module exploits a PHP unserialize() vulnerability in Drupal RESTful
Severity: Major
Found in modules/exploits/unix/webapp/drupal_restws_unserialize.rb - About 2 hrs to fix

    Method execute_command has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def execute_command(cmd, opts = {})
    vprint_status("Executing with system(): #{cmd}")

    # https://en.wikipedia.org/wiki/Hypertext_Application_Language
    hal_json = JSON.pretty_generate(
    Severity: Minor
    Found in modules/exploits/unix/webapp/drupal_restws_unserialize.rb - About 1 hr to fix

      Method check has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    checkcode = CheckCode::Unknown

    version = drupal_version
      Severity: Minor
      Found in modules/exploits/unix/webapp/drupal_restws_unserialize.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    checkcode = CheckCode::Unknown

    version = drupal_version
        Severity: Minor
        Found in modules/exploits/unix/webapp/drupal_restws_unserialize.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method execute_command has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def execute_command(cmd, opts = {})
    vprint_status("Executing with system(): #{cmd}")

    # https://en.wikipedia.org/wiki/Hypertext_Application_Language
    hal_json = JSON.pretty_generate(
        Severity: Minor
        Found in modules/exploits/unix/webapp/drupal_restws_unserialize.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return checkcode unless res
        Severity: Major
        Found in modules/exploits/unix/webapp/drupal_restws_unserialize.rb - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case drupal_patch(changelog, 'SA-CORE-2019-003')
    when nil
      vprint_warning('CHANGELOG.txt no longer contains patch level')
    when true
      vprint_warning('Drupal appears patched in CHANGELOG.txt')
          Severity: Minor
          Found in modules/exploits/unix/webapp/drupal_restws_unserialize.rb and 1 other location - About 15 mins to fix
          modules/exploits/unix/webapp/drupal_drupalgeddon2.rb on lines 164..173

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status