Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/webapp/openmediavault_rpc_rce.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'OpenMediaVault rpc.php Authenticated PHP Code Injection',
Severity: Major
Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 2 hrs to fix

    Method check has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    res = login(user, pass)
    unless res
      return CheckCode::Unknown("No response was received from #{peer} whilst in check(), check it is online and the target port is open!")
    end
    Severity: Minor
    Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    res = login(user, pass)
    unless res
      return CheckCode::Unknown("No response was received from #{peer} whilst in check(), check it is online and the target port is open!")
    end
    Severity: Minor
    Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 1 hr to fix

      Method get_target has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_target
    print_status("#{peer} - Trying to detect if target is running a supported version of OpenMediaVault.")
    res = send_request_cgi({
      'uri' => @uri,
      'method' => 'POST',
      Severity: Minor
      Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 1 hr to fix

        Method login has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def login(user, pass, _opts = {})
    print_status("#{peer} - Authenticating with OpenMediaVault using #{user}:#{pass}...")
    @uri = normalize_uri(target_uri.path, '/rpc.php')
    res = send_request_cgi({
      'uri' => @uri,
        Severity: Minor
        Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 1 hr to fix

          Method login has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def login(user, pass, _opts = {})
    print_status("#{peer} - Authenticating with OpenMediaVault using #{user}:#{pass}...")
    @uri = normalize_uri(target_uri.path, '/rpc.php')
    res = send_request_cgi({
      'uri' => @uri,
          Severity: Minor
          Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                return nil
          Severity: Major
          Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return CheckCode::Safe
            Severity: Major
            Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return CheckCode::Vulnerable
              Severity: Major
              Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return CheckCode::Unknown
                Severity: Major
                Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 30 mins to fix

                  Method get_target has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def get_target
    print_status("#{peer} - Trying to detect if target is running a supported version of OpenMediaVault.")
    res = send_request_cgi({
      'uri' => @uri,
      'method' => 'POST',
                  Severity: Minor
                  Found in modules/exploits/unix/webapp/openmediavault_rpc_rce.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  There are no issues that match your filters.

                  Category
                  Status