Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/webapp/piwik_superuser_plugin_upload.rb

Summary

Maintainability
D
2 days
Test Coverage

Method exploit has 194 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    print_status('Trying to detect if target is running a supported version of piwik')
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalized_index
Severity: Major
Found in modules/exploits/unix/webapp/piwik_superuser_plugin_upload.rb - About 7 hrs to fix

    Method exploit has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    print_status('Trying to detect if target is running a supported version of piwik')
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalized_index
    Severity: Minor
    Found in modules/exploits/unix/webapp/piwik_superuser_plugin_upload.rb - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File piwik_superuser_plugin_upload.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'rex/zip'

class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking
    Severity: Minor
    Found in modules/exploits/unix/webapp/piwik_superuser_plugin_upload.rb - About 3 hrs to fix

      Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(update_info(
      info,
      'Name'            => 'Piwik Superuser Plugin Upload',
      'Description'     => %q{
      Severity: Minor
      Found in modules/exploits/unix/webapp/piwik_superuser_plugin_upload.rb - About 1 hr to fix

        Method get_piwik_version has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def get_piwik_version(login_cookies)
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalized_index,
      'cookie' => login_cookies,
        Severity: Minor
        Found in modules/exploits/unix/webapp/piwik_superuser_plugin_upload.rb - About 1 hr to fix

          Method get_piwik_version has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def get_piwik_version(login_cookies)
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalized_index,
      'cookie' => login_cookies,
          Severity: Minor
          Found in modules/exploits/unix/webapp/piwik_superuser_plugin_upload.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status