modules/exploits/unix/webapp/projectsend_upload_exec.rb
Method check has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
Open
def check
res = send_request_cgi(
'uri' => normalize_uri(target_uri.path, 'process-upload.php')
)
if !res- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def initialize(info={})
super(update_info(info,
'Name' => 'ProjectSend Arbitrary File Upload',
'Description' => %q{
This module exploits a file upload vulnerability in ProjectSendMethod upload has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def upload
fname = "#{rand_text_alphanumeric(rand(10) + 6)}.php"
php = "<?php #{payload.encoded} ?>"
data = Rex::MIME::Message.new
data.add_part(php, 'application/octet-stream', nil, %(form-data; name="file"; filename="#{fname}"))Method check has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def check
res = send_request_cgi(
'uri' => normalize_uri(target_uri.path, 'process-upload.php')
)
if !resMethod upload has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
def upload
fname = "#{rand_text_alphanumeric(rand(10) + 6)}.php"
php = "<?php #{payload.encoded} ?>"
data = Rex::MIME::Message.new
data.add_part(php, 'application/octet-stream', nil, %(form-data; name="file"; filename="#{fname}"))- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
Open
return Exploit::CheckCode::DetectedAvoid too many return statements within this method. Open
Open
return Exploit::CheckCode::SafeAvoid too many return statements within this method. Open
Open
return Exploit::CheckCode::SafeAvoid too many return statements within this method. Open
Open
return Exploit::CheckCode::AppearsAvoid too many return statements within this method. Open
Open
return Exploit::CheckCode::SafeAvoid too many return statements within this method. Open
Open
return Exploit::CheckCode::Vulnerable