Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/unix/webapp/trixbox_ce_endpoint_devicemap_rce.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'TrixBox CE endpoint_devicemap.php Authenticated Command Execution',
Severity: Major
Found in modules/exploits/unix/webapp/trixbox_ce_endpoint_devicemap_rce.rb - About 2 hrs to fix

    Method check has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    res = login(user, pass)
    unless res
      print_error("No response was received from #{peer} whilst in check(), check it is online and the target port is open!")
      return CheckCode::Detected
    Severity: Minor
    Found in modules/exploits/unix/webapp/trixbox_ce_endpoint_devicemap_rce.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exploit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    res = login(user, pass)
    unless res
      print_error("No response was received from #{peer} whilst in exploit(), check it is online and the target port is open!")
    end
    Severity: Minor
    Found in modules/exploits/unix/webapp/trixbox_ce_endpoint_devicemap_rce.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
    res = login(user, pass)
    unless res
      print_error("No response was received from #{peer} whilst in check(), check it is online and the target port is open!")
      return CheckCode::Detected
    Severity: Minor
    Found in modules/exploits/unix/webapp/trixbox_ce_endpoint_devicemap_rce.rb - About 1 hr to fix

      Method login has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def login(user, pass, _opts = {})
    uri = normalize_uri(target_uri.path, '/maint/')
    print_status("#{peer} - Authenticating using \"#{user}:#{pass}\" credentials...")
    res = send_request_cgi({
      'uri' => uri,
      Severity: Minor
      Found in modules/exploits/unix/webapp/trixbox_ce_endpoint_devicemap_rce.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_target has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_target(res)
    version = res.body.scan(/v(\d.\d.{0,1}\d{0,1}.{0,1}\d{0,1})/).flatten.first
    if version.nil?
      version = res.body.scan(/Version: (\d.\d.{0,1}\d{0,1}.{0,1}\d{0,1})/).flatten.first
      if version.nil?
      Severity: Minor
      Found in modules/exploits/unix/webapp/trixbox_ce_endpoint_devicemap_rce.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return CheckCode::Safe
      Severity: Major
      Found in modules/exploits/unix/webapp/trixbox_ce_endpoint_devicemap_rce.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return CheckCode::Unknown
        Severity: Major
        Found in modules/exploits/unix/webapp/trixbox_ce_endpoint_devicemap_rce.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status